diff options
author | 2015-12-07 22:22:56 -0800 | |
---|---|---|
committer | 2015-12-07 22:22:56 -0800 | |
commit | b50ae4651bf1043a30e4db20cd4b4d3ca2cadfe4 (patch) | |
tree | addc94dc99fb5d161fe91b54e638eb7f764ad47b /src/node | |
parent | f1183300ce40c957fc9010e8513c15a15d11afd4 (diff) | |
parent | 045c8483c2d78421d40bf88112e012e1624a0d93 (diff) |
merge with head
Diffstat (limited to 'src/node')
-rw-r--r-- | src/node/ext/call.cc | 5 | ||||
-rw-r--r-- | src/node/src/credentials.js | 5 |
2 files changed, 6 insertions, 4 deletions
diff --git a/src/node/ext/call.cc b/src/node/ext/call.cc index 1b2ab21dfe..c0e2b0f0e8 100644 --- a/src/node/ext/call.cc +++ b/src/node/ext/call.cc @@ -234,7 +234,9 @@ class SendMetadataOp : public Op { class SendMessageOp : public Op { public: - SendMessageOp() { send_message = NULL; } + SendMessageOp() { + send_message = NULL; + } ~SendMessageOp() { if (send_message != NULL) { grpc_byte_buffer_destroy(send_message); @@ -269,7 +271,6 @@ class SendMessageOp : public Op { std::string GetTypeString() const { return "send_message"; } - private: grpc_byte_buffer *send_message; }; diff --git a/src/node/src/credentials.js b/src/node/src/credentials.js index ff10a22e6a..dcbfac18f4 100644 --- a/src/node/src/credentials.js +++ b/src/node/src/credentials.js @@ -91,7 +91,7 @@ exports.createSsl = ChannelCredentials.createSsl; */ exports.createFromMetadataGenerator = function(metadata_generator) { return CallCredentials.createFromPlugin(function(service_url, callback) { - metadata_generator(service_url, function(error, metadata) { + metadata_generator({service_url: service_url}, function(error, metadata) { var code = grpc.status.OK; var message = ''; if (error) { @@ -114,7 +114,8 @@ exports.createFromMetadataGenerator = function(metadata_generator) { * @return {CallCredentials} The resulting credentials object */ exports.createFromGoogleCredential = function(google_credential) { - return exports.createFromMetadataGenerator(function(service_url, callback) { + return exports.createFromMetadataGenerator(function(auth_context, callback) { + var service_url = auth_context.service_url; google_credential.getRequestMetadata(service_url, function(err, header) { if (err) { callback(err); |