aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/node/ext/byte_buffer.cc
diff options
context:
space:
mode:
authorGravatar Marek Gilbert <mcg@google.com>2016-01-26 05:53:11 -0800
committerGravatar Marek Gilbert <mcg@google.com>2016-01-26 05:53:11 -0800
commit16110eee6a04b61bb69425221d6e52b641c05e33 (patch)
tree0ec1ba9437af4daeb6ad15f965abf42182e4e6d7 /src/node/ext/byte_buffer.cc
parent7c43f4909242b62881389c7d4cfc9541c70151b6 (diff)
Allocate node Buffer contents with new[]
Nan::NewBuffer(char* data, uint32_t size) frees the provided buffer by calling delete[]. This matches the allocation method to the free method. Fixes grpc/grpc#4867.
Diffstat (limited to 'src/node/ext/byte_buffer.cc')
-rw-r--r--src/node/ext/byte_buffer.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node/ext/byte_buffer.cc b/src/node/ext/byte_buffer.cc
index c306292c04..4878219aca 100644
--- a/src/node/ext/byte_buffer.cc
+++ b/src/node/ext/byte_buffer.cc
@@ -69,7 +69,7 @@ Local<Value> ByteBufferToBuffer(grpc_byte_buffer *buffer) {
return scope.Escape(Nan::Null());
}
size_t length = grpc_byte_buffer_length(buffer);
- char *result = reinterpret_cast<char *>(calloc(length, sizeof(char)));
+ char *result = new char[length];
size_t offset = 0;
grpc_byte_buffer_reader reader;
grpc_byte_buffer_reader_init(&reader, buffer);