diff options
author | easy <g-easy@users.noreply.github.com> | 2018-12-19 12:22:38 +1100 |
---|---|---|
committer | easy <g-easy@users.noreply.github.com> | 2018-12-19 12:37:39 +1100 |
commit | 82797771679c93045876f48707c5cb46bfae4f53 (patch) | |
tree | f1fcd596e7808fb494e10cd6739fed3e069d4631 /src/cpp | |
parent | 8114c05a2f84515c0f36c227d37925375f7002c5 (diff) |
Destruct CensusContext to avoid leaking memory.
Otherwise, the placement-new leaks context -> span_ -> impl_ which is
a std::shared_ptr.
Diffstat (limited to 'src/cpp')
-rw-r--r-- | src/cpp/ext/filters/census/context.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/cpp/ext/filters/census/context.cc b/src/cpp/ext/filters/census/context.cc index 78fc69a805..160590353a 100644 --- a/src/cpp/ext/filters/census/context.cc +++ b/src/cpp/ext/filters/census/context.cc @@ -28,6 +28,9 @@ using ::opencensus::trace::SpanContext; void GenerateServerContext(absl::string_view tracing, absl::string_view stats, absl::string_view primary_role, absl::string_view method, CensusContext* context) { + // Destruct the current CensusContext to free the Span memory before + // overwriting it below. + context->~CensusContext(); GrpcTraceContext trace_ctxt; if (TraceContextEncoding::Decode(tracing, &trace_ctxt) != TraceContextEncoding::kEncodeDecodeFailure) { @@ -42,6 +45,9 @@ void GenerateServerContext(absl::string_view tracing, absl::string_view stats, void GenerateClientContext(absl::string_view method, CensusContext* ctxt, CensusContext* parent_ctxt) { + // Destruct the current CensusContext to free the Span memory before + // overwriting it below. + ctxt->~CensusContext(); if (parent_ctxt != nullptr) { SpanContext span_ctxt = parent_ctxt->Context(); Span span = parent_ctxt->Span(); |