aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/cpp/thread_manager
diff options
context:
space:
mode:
authorGravatar Sree Kuchibhotla <sreek@google.com>2018-07-27 16:19:03 -0700
committerGravatar Sree Kuchibhotla <sreek@google.com>2018-07-27 16:19:03 -0700
commitc2a22a1ab8e8221c95f8874668eb6260c1e171b4 (patch)
tree6a1de70b7e4d8c82ef1eba01c7a92f91c4d31333 /src/cpp/thread_manager
parent9bc8ee42c20385214027ced5991b9973a0282655 (diff)
Address core review comments
Diffstat (limited to 'src/cpp/thread_manager')
-rw-r--r--src/cpp/thread_manager/thread_manager.cc6
-rw-r--r--src/cpp/thread_manager/thread_manager.h7
2 files changed, 7 insertions, 6 deletions
diff --git a/src/cpp/thread_manager/thread_manager.cc b/src/cpp/thread_manager/thread_manager.cc
index 5d367511e2..57067d4696 100644
--- a/src/cpp/thread_manager/thread_manager.cc
+++ b/src/cpp/thread_manager/thread_manager.cc
@@ -123,7 +123,7 @@ void ThreadManager::CleanupCompletedThreads() {
}
void ThreadManager::Initialize() {
- if (!grpc_resource_user_alloc_threads(resource_user_, min_pollers_)) {
+ if (!grpc_resource_user_allocate_threads(resource_user_, min_pollers_)) {
gpr_log(GPR_ERROR,
"No thread quota available to even create the minimum required "
"polling threads (i.e %d). Unable to start the thread manager",
@@ -165,9 +165,9 @@ void ThreadManager::MainWorkLoop() {
break;
case WORK_FOUND:
// If we got work and there are now insufficient pollers and there is
- // quota available to create a new thread,start a new poller thread
+ // quota available to create a new thread, start a new poller thread
if (!shutdown_ && num_pollers_ < min_pollers_ &&
- grpc_resource_user_alloc_threads(resource_user_, 1)) {
+ grpc_resource_user_allocate_threads(resource_user_, 1)) {
num_pollers_++;
num_threads_++;
max_active_threads_sofar_ =
diff --git a/src/cpp/thread_manager/thread_manager.h b/src/cpp/thread_manager/thread_manager.h
index 8332befed0..01043edb31 100644
--- a/src/cpp/thread_manager/thread_manager.h
+++ b/src/cpp/thread_manager/thread_manager.h
@@ -100,7 +100,7 @@ class ThreadManager {
// ThreadManager::MarkAsCompleted()
//
// WHY IS THIS NEEDED?:
- // When a thread terminates, some other tread *must* call Join() on that
+ // When a thread terminates, some other thread *must* call Join() on that
// thread so that the resources are released. Having a WorkerThread wrapper
// will make this easier. Once Run() completes, each thread calls the
// following two functions:
@@ -113,8 +113,9 @@ class ThreadManager {
// in the completed_threads_ list (since a thread cannot call Join() on
// itself, it calls CleanupCompletedThreads() *before* calling
// MarkAsCompleted())
- // TODO: sreek - consider creating the threads 'detached' so that Join() need
- // not be called
+ //
+ // TODO(sreek): Consider creating the threads 'detached' so that Join() need
+ // not be called (and the need for this WorkerThread class is eliminated)
class WorkerThread {
public:
WorkerThread(ThreadManager* thd_mgr);