diff options
| author |  Vijay Pai <vpai@google.com> | 2018-09-19 12:58:02 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-09-19 12:58:02 -0700 |
| commit | f6e7b778c42da01610f914271ccddee49becb2fa (patch) | |
| tree | f38bcb94592cf752085c9a4200e19e0636a45dba /src/cpp/common | |
| parent | a0578f075ccd64a7041c02c0efcf3bb590aa019e (diff) | |
| parent | deb3126611a513b768052d93a976832985640d9f (diff) | |
Merge pull request #16655 from vjpai/callback_tidy
Callback API: Fix clang-tidy concerns
Diffstat (limited to 'src/cpp/common')
| -rw-r--r-- | src/cpp/common/callback_common.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cpp/common/callback_common.cc b/src/cpp/common/callback_common.cc index fa586286d1..a0c8eeb516 100644 --- a/src/cpp/common/callback_common.cc +++ b/src/cpp/common/callback_common.cc @@ -66,8 +66,8 @@ class CallbackWithSuccessImpl : public grpc_core::CQCallbackInterface { GPR_ASSERT(parent_->ops()->FinalizeResult(&ignored, &new_ok)); GPR_ASSERT(ignored == parent_->ops()); - // Last use of func_ or ok, so ok to move them out for rvalue call above - CatchingCallback(std::move(func_), std::move(ok)); + // Last use of func_, so ok to move it out for rvalue call above + CatchingCallback(std::move(func_), ok); func_ = nullptr; // reset to clear this out for sure grpc_call_unref(call_); |