aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core
diff options
context:
space:
mode:
authorGravatar David Garcia Quintas <dgq@google.com>2015-10-06 11:05:05 -0700
committerGravatar David Garcia Quintas <dgq@google.com>2015-10-06 11:05:05 -0700
commit35284f0c8442ae31dc9057583d2064c5257fae4f (patch)
tree0ad8f44503df9b00f24f97ab8502839d90834811 /src/core
parent760cd88eafaa4098eae2ab8b3935ff8e398c9332 (diff)
Simplified comments
Diffstat (limited to 'src/core')
-rw-r--r--src/core/surface/call.c15
-rw-r--r--src/core/transport/chttp2/bin_encoder.c10
2 files changed, 10 insertions, 15 deletions
diff --git a/src/core/surface/call.c b/src/core/surface/call.c
index ad022f43b1..6b0395ab00 100644
--- a/src/core/surface/call.c
+++ b/src/core/surface/call.c
@@ -427,9 +427,8 @@ static grpc_cq_completion *allocate_completion(grpc_call *call) {
}
/* NB: the following integer arithmetic operation needs to be in its
* expanded form due to the "integral promotion" performed (see section
- * 3.2.1.1 of the C89 draft standard), which in this case upcasts the result
- * of the bitwise OR to "unsigned". A cast to the smaller container type is
- * then required to avoid the compiler warning */
+ * 3.2.1.1 of the C89 draft standard). A cast to the smaller container type
+ * is then required to avoid the compiler warning */
call->allocated_completions =
(gpr_uint8)(call->allocated_completions | (1u << i));
gpr_mu_unlock(&call->completion_mu);
@@ -744,9 +743,8 @@ static void finish_live_ioreq_op(grpc_call *call, grpc_ioreq_op op,
master = &call->masters[master_set];
/* NB: the following integer arithmetic operation needs to be in its
* expanded form due to the "integral promotion" performed (see section
- * 3.2.1.1 of the C89 draft standard), which in this case upcasts the result
- * of the bitwise OR to "unsigned". A cast to the smaller container type is
- * then required to avoid the compiler warning */
+ * 3.2.1.1 of the C89 draft standard). A cast to the smaller container type
+ * is then required to avoid the compiler warning */
master->complete_mask = (gpr_uint16)(master->complete_mask | (1u << op));
if (!success) {
master->success = 0;
@@ -1259,9 +1257,8 @@ static grpc_call_error start_ioreq(grpc_call *call, const grpc_ioreq *reqs,
}
/* NB: the following integer arithmetic operation needs to be in its
* expanded form due to the "integral promotion" performed (see section
- * 3.2.1.1 of the C89 draft standard), which in this case upcasts the result
- * of the bitwise OR to "unsigned". A cast to the smaller container type is
- * then required to avoid the compiler warning */
+ * 3.2.1.1 of the C89 draft standard). A cast to the smaller container type
+ * is then required to avoid the compiler warning */
have_ops = (gpr_uint16)(have_ops | (1u << op));
call->request_data[op] = data;
diff --git a/src/core/transport/chttp2/bin_encoder.c b/src/core/transport/chttp2/bin_encoder.c
index 5266f3ebf7..9c9070ede4 100644
--- a/src/core/transport/chttp2/bin_encoder.c
+++ b/src/core/transport/chttp2/bin_encoder.c
@@ -187,9 +187,8 @@ gpr_slice grpc_chttp2_huffman_compress(gpr_slice input) {
if (temp_length) {
/* NB: the following integer arithmetic operation needs to be in its
* expanded form due to the "integral promotion" performed (see section
- * 3.2.1.1 of the C89 draft standard), which in this case upcasts the result
- * of the bitwise OR to "unsigned". A cast to the smaller container type is
- * then required to avoid the compiler warning */
+ * 3.2.1.1 of the C89 draft standard). A cast to the smaller container type
+ * is then required to avoid the compiler warning */
*out++ = (gpr_uint8)((gpr_uint8)(temp << (8u - temp_length)) |
(gpr_uint8)(0xffu >> temp_length));
}
@@ -272,9 +271,8 @@ gpr_slice grpc_chttp2_base64_encode_and_huffman_compress(gpr_slice input) {
if (out.temp_length) {
/* NB: the following integer arithmetic operation needs to be in its
* expanded form due to the "integral promotion" performed (see section
- * 3.2.1.1 of the C89 draft standard), which in this case upcasts the result
- * of the bitwise OR to "unsigned". A cast to the smaller container type is
- * then required to avoid the compiler warning */
+ * 3.2.1.1 of the C89 draft standard). A cast to the smaller container type
+ * is then required to avoid the compiler warning */
*out.out++ = (gpr_uint8)((gpr_uint8)(out.temp << (8u - out.temp_length)) |
(gpr_uint8)(0xffu >> out.temp_length));
}