diff options
| author |  Julien Boeuf <jboeuf@google.com> | 2015-06-18 23:29:13 +0200 |
|---|---|---|
| committer | Julien Boeuf <jboeuf@google.com> | 2015-06-18 23:29:13 +0200 |
| commit | 3e29de19a3768f277a76e1da2f26ed17c591cc37 (patch) | |
| tree | a5f60ff73094405da3f19d4410e0506b330aa9b7 /src/core/tsi | |
| parent | d1531323e7dc5ee8e4f562bc251d1de5eb0a8b0c (diff) | |
Adressing comments.
Diffstat (limited to 'src/core/tsi')
| -rw-r--r-- | src/core/tsi/ssl_transport_security.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/core/tsi/ssl_transport_security.c b/src/core/tsi/ssl_transport_security.c index bd4c15a068..6156a39d09 100644 --- a/src/core/tsi/ssl_transport_security.c +++ b/src/core/tsi/ssl_transport_security.c @@ -54,12 +54,16 @@ #define TSI_SSL_MAX_PROTECTED_FRAME_SIZE_UPPER_BOUND 16384 #define TSI_SSL_MAX_PROTECTED_FRAME_SIZE_LOWER_BOUND 1024 + +/* Putting a macro like this and littering the source file with #if is really + bad practice. + TODO(jboeuf): refactor all the #if / #endif in a separate module. */ #ifndef TSI_OPENSSL_ALPN_SUPPORT #define TSI_OPENSSL_ALPN_SUPPORT 1 #endif /* TODO(jboeuf): I have not found a way to get this number dynamically from the - * SSL structure. This is what we would ultimately want though... */ + SSL structure. This is what we would ultimately want though... */ #define TSI_SSL_MAX_PROTECTION_OVERHEAD 100 /* --- Structure definitions. ---*/ |