aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/lib
diff options
context:
space:
mode:
authorGravatar Mark D. Roth <roth@google.com>2016-10-11 11:03:27 -0700
committerGravatar Mark D. Roth <roth@google.com>2016-10-11 11:03:27 -0700
commitc1c38586dedfb4368372a2de03df1645a2a9ee7f (patch)
tree01f8df9414db4942a149e7f1c7790f5cf157f4f6 /src/core/lib
parent83b7016b296b9e338d80f36c5118c843ce2b4967 (diff)
Code review changes.
Diffstat (limited to 'src/core/lib')
-rw-r--r--src/core/lib/channel/message_size_filter.c4
-rw-r--r--src/core/lib/transport/hashtable.c9
-rw-r--r--src/core/lib/transport/hashtable.h5
3 files changed, 10 insertions, 8 deletions
diff --git a/src/core/lib/channel/message_size_filter.c b/src/core/lib/channel/message_size_filter.c
index dbd8afd465..1382f19945 100644
--- a/src/core/lib/channel/message_size_filter.c
+++ b/src/core/lib/channel/message_size_filter.c
@@ -137,14 +137,14 @@ static grpc_error* init_call_elem(grpc_exec_ctx* exec_ctx,
grpc_method_config_table_get_method_config(chand->method_config_table,
args->path);
if (method_config != NULL) {
- int32_t* max_request_message_bytes =
+ const int32_t* max_request_message_bytes =
grpc_method_config_get_max_request_message_bytes(method_config);
if (max_request_message_bytes != NULL &&
(*max_request_message_bytes < calld->max_send_size ||
calld->max_send_size < 0)) {
calld->max_send_size = *max_request_message_bytes;
}
- int32_t* max_response_message_bytes =
+ const int32_t* max_response_message_bytes =
grpc_method_config_get_max_response_message_bytes(method_config);
if (max_response_message_bytes != NULL &&
(*max_response_message_bytes < calld->max_recv_size ||
diff --git a/src/core/lib/transport/hashtable.c b/src/core/lib/transport/hashtable.c
index 838fe1026e..d127f17a37 100644
--- a/src/core/lib/transport/hashtable.c
+++ b/src/core/lib/transport/hashtable.c
@@ -47,8 +47,8 @@ struct grpc_hash_table {
// Helper function for insert and get operations that performs quadratic
// probing (https://en.wikipedia.org/wiki/Quadratic_probing).
-static size_t grpc_hash_table_find_index(grpc_hash_table* table,
- grpc_mdstr* key, bool find_empty) {
+static size_t grpc_hash_table_find_index(
+ const grpc_hash_table* table, const grpc_mdstr* key, bool find_empty) {
for (size_t i = 0; i < table->num_entries; ++i) {
const size_t idx = (key->hash + i * i) % table->num_entries;
if (table->entries[idx].key == NULL)
@@ -111,14 +111,15 @@ int grpc_hash_table_unref(grpc_hash_table* table) {
return 0;
}
-void* grpc_hash_table_get(grpc_hash_table* table, grpc_mdstr* key) {
+void* grpc_hash_table_get(const grpc_hash_table* table, const grpc_mdstr* key) {
const size_t idx =
grpc_hash_table_find_index(table, key, false /* find_empty */);
if (idx == table->num_entries) return NULL; // Not found.
return table->entries[idx].value;
}
-int grpc_hash_table_cmp(grpc_hash_table* table1, grpc_hash_table* table2) {
+int grpc_hash_table_cmp(const grpc_hash_table* table1,
+ const grpc_hash_table* table2) {
// Compare by num_entries.
if (table1->num_entries < table2->num_entries) return -1;
if (table1->num_entries > table2->num_entries) return 1;
diff --git a/src/core/lib/transport/hashtable.h b/src/core/lib/transport/hashtable.h
index 3ec48dce3a..0ce51383c7 100644
--- a/src/core/lib/transport/hashtable.h
+++ b/src/core/lib/transport/hashtable.h
@@ -74,9 +74,10 @@ int grpc_hash_table_unref(grpc_hash_table* table);
/** Returns the value from \a table associated with \a key.
Returns NULL if \a key is not found. */
-void* grpc_hash_table_get(grpc_hash_table* table, grpc_mdstr* key);
+void* grpc_hash_table_get(const grpc_hash_table* table, const grpc_mdstr* key);
/** Compares two hash tables. */
-int grpc_hash_table_cmp(grpc_hash_table* table1, grpc_hash_table* table2);
+int grpc_hash_table_cmp(const grpc_hash_table* table1,
+ const grpc_hash_table* table2);
#endif /* GRPC_CORE_LIB_TRANSPORT_HASHTABLE_H */