reviewer comment

2 files changed, 3 insertions, 13 deletions

diff --git a/src/core/lib/channel/channel_tracer.cc b/src/core/lib/channel/channel_tracer.cc
index 982b86447d..b1c76408a0 100644
--- a/src/core/lib/channel/channel_tracer.cc
+++ b/src/core/lib/channel/channel_tracer.cc
@@ -307,12 +307,4 @@ char* ChannelTrace::RenderTrace(bool recursive) {
   return renderer.Run();
 }
 
-char* ChannelTrace::GetChannelTraceFromUuid(intptr_t uuid, bool recursive) {
-  void* object;
-  grpc_object_registry_type type =
-      grpc_object_registry_get_object(uuid, &object);
-  GPR_ASSERT(type == GRPC_OBJECT_REGISTRY_CHANNEL_TRACER);
-  return static_cast<ChannelTrace*>(object)->RenderTrace(recursive);
-}
-
 }  // namespace grpc_core
diff --git a/src/core/lib/channel/channel_tracer.h b/src/core/lib/channel/channel_tracer.h
index 72bdee48f8..e3ab32cfcd 100644
--- a/src/core/lib/channel/channel_tracer.h
+++ b/src/core/lib/channel/channel_tracer.h
@@ -43,7 +43,9 @@ class ChannelTrace : public RefCounted<ChannelTrace> {
 
   /* Adds a new trace event to the tracing object. This trace event refers to a
      an event on a child of the channel. For example this could log when a
-     particular subchannel becomes connected */
+     particular subchannel becomes connected.
+     TODO(ncteisen): Once channelz is implemented, the events should reference
+     the channelz object, not the channel trace. */
   void AddTraceEvent(grpc_slice data, grpc_error* error,
                      grpc_connectivity_state connectivity_state,
                      RefCountedPtr<ChannelTrace> referenced_tracer);
@@ -54,10 +56,6 @@ class ChannelTrace : public RefCounted<ChannelTrace> {
      subtracing objects. */
   char* RenderTrace(bool recursive);
 
-  /* util functions that perform the uuid -> tracer step for you, and then
-     returns the trace for the uuid given. */
-  static char* GetChannelTraceFromUuid(intptr_t uuid, bool recursive);
-
  private:
   // Internal helper to add and link in a trace event
   void AddTraceEventHelper(TraceEvent* new_trace_event);