aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/lib/surface/call.cc
diff options
context:
space:
mode:
authorGravatar Yash Tibrewal <yashkt@google.com>2017-11-13 15:37:58 -0800
committerGravatar Yash Tibrewal <yashkt@google.com>2017-11-14 01:36:28 -0800
commit75122c23578e24417dcf64081c737571a9fc2dbc (patch)
treef4b8491964ec0508a5826490628c9f87b82c3326 /src/core/lib/surface/call.cc
parent36cd68f0d543b9024c84eff82319890a791de7f6 (diff)
Address some PR comments
Diffstat (limited to 'src/core/lib/surface/call.cc')
-rw-r--r--src/core/lib/surface/call.cc7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/core/lib/surface/call.cc b/src/core/lib/surface/call.cc
index 5e1c0badd0..bbb7a39e29 100644
--- a/src/core/lib/surface/call.cc
+++ b/src/core/lib/surface/call.cc
@@ -595,7 +595,7 @@ void grpc_call_unref(grpc_call* c) {
grpc_call_combiner_set_notify_on_cancel(&c->call_combiner, NULL);
}
GRPC_CALL_INTERNAL_UNREF(c, "destroy");
- grpc_exec_ctx_finish();
+
GPR_TIMER_END("grpc_call_unref", 0);
}
@@ -604,7 +604,7 @@ grpc_call_error grpc_call_cancel(grpc_call* call, void* reserved) {
GPR_ASSERT(!reserved);
ExecCtx _local_exec_ctx;
cancel_with_error(call, STATUS_FROM_API_OVERRIDE, GRPC_ERROR_CANCELLED);
- grpc_exec_ctx_finish();
+
return GRPC_CALL_OK;
}
@@ -659,7 +659,7 @@ grpc_call_error grpc_call_cancel_with_status(grpc_call* c,
4, (c, (int)status, description, reserved));
GPR_ASSERT(reserved == NULL);
cancel_with_status(c, STATUS_FROM_API_OVERRIDE, status, description);
- grpc_exec_ctx_finish();
+
return GRPC_CALL_OK;
}
@@ -2048,7 +2048,6 @@ grpc_call_error grpc_call_start_batch(grpc_call* call, const grpc_op* ops,
err = call_start_batch(call, ops, nops, tag, 0);
}
- grpc_exec_ctx_finish();
return err;
}