aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/lib/iomgr/timer.h
diff options
context:
space:
mode:
authorGravatar Sree Kuchibhotla <sreek@google.com>2017-11-16 21:35:54 -0800
committerGravatar Sree Kuchibhotla <sreek@google.com>2017-11-17 09:44:07 -0800
commit9f4759ac144db54c638a7dc9d1c1ee7ba6208c7a (patch)
tree11dd8cc749a8c625a40a8274e3329bbd34c0b3cd /src/core/lib/iomgr/timer.h
parentd9186a7e9ddce582861a8adab89d6ac58da7eb41 (diff)
Disable caching start-time for all clocktypes except GPR_CLOCK_MONOTONIC
Caching the start-time for GPR_CLOCK_REALTIME has been causing errors in cases where the system time is changed (after caching the time). In such cases, the following functions produce incorrect results (and are off by how much ever the system time was changed) grpc_millis_to_timespec() and grpc_timespec_to_millis_round_down() This can cause problems especially when using the above functions to get timer deadlines or completion queue timeouts. (In the worst case scenarios, the timeouts/deadlines will always occur (if the timeout inverval / deadline was less than the system change delta) Ideally we should be reverting https://github.com/grpc/grpc/pull/11866 but since that is a large change (which introduced new APIs in exec_ctx.cc), I am doing this change to effectively revert to the old behavior (while still keeping the new APIs introduced in exec_ctx)
Diffstat (limited to 'src/core/lib/iomgr/timer.h')
0 files changed, 0 insertions, 0 deletions