diff options
author | ncteisen <ncteisen@gmail.com> | 2018-06-11 15:19:06 -0700 |
---|---|---|
committer | ncteisen <ncteisen@gmail.com> | 2018-06-13 15:01:05 -0700 |
commit | 1198d8dfc625ce123c591d8f5079e75f23f772e5 (patch) | |
tree | 5237875767d8ee43a69b85a183619b5f77514d13 /src/core/lib/iomgr/tcp_server_posix.cc | |
parent | f82e28fb6f6d94f37bc646c1899f2e412e4b949e (diff) |
Reviewer feedback
Diffstat (limited to 'src/core/lib/iomgr/tcp_server_posix.cc')
-rw-r--r-- | src/core/lib/iomgr/tcp_server_posix.cc | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/core/lib/iomgr/tcp_server_posix.cc b/src/core/lib/iomgr/tcp_server_posix.cc index 0efdeab80e..0a9b4bfd5f 100644 --- a/src/core/lib/iomgr/tcp_server_posix.cc +++ b/src/core/lib/iomgr/tcp_server_posix.cc @@ -63,14 +63,12 @@ static grpc_error* tcp_server_create(grpc_closure* shutdown_complete, s->so_reuseport = grpc_is_socket_reuse_port_supported(); s->expand_wildcard_addrs = false; for (size_t i = 0; i < (args == nullptr ? 0 : args->num_args); i++) { - // TODO(roth): I chose that these both default to true. Is this reasonable? - // Before they would create errors, so this is actually making the - // restrictions more lenient. if (0 == strcmp(GRPC_ARG_ALLOW_REUSEPORT, args->args[i].key)) { - s->so_reuseport = grpc_channel_arg_get_bool(&args->args[i], true); + s->so_reuseport = grpc_channel_arg_get_bool( + &args->args[i], grpc_is_socket_reuse_port_supported()); } else if (0 == strcmp(GRPC_ARG_EXPAND_WILDCARD_ADDRS, args->args[i].key)) { s->expand_wildcard_addrs = - grpc_channel_arg_get_bool(&args->args[i], true); + grpc_channel_arg_get_bool(&args->args[i], false); } } gpr_ref_init(&s->refs, 1); |