diff options
author | 2018-09-28 19:48:38 -0700 | |
---|---|---|
committer | 2018-09-28 19:48:38 -0700 | |
commit | f443f185b3dd4b694e9719d7e730e98396416ce8 (patch) | |
tree | 8ad2a527efcb5f6022067176a28ad8cb8d4c9073 /src/core/lib/iomgr/tcp_posix.cc | |
parent | 631181d68ddb143ba78016d254c79cbcd107f91c (diff) |
Address feedback comment
Diffstat (limited to 'src/core/lib/iomgr/tcp_posix.cc')
-rw-r--r-- | src/core/lib/iomgr/tcp_posix.cc | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/src/core/lib/iomgr/tcp_posix.cc b/src/core/lib/iomgr/tcp_posix.cc index 4aad83915f..e40bf81c90 100644 --- a/src/core/lib/iomgr/tcp_posix.cc +++ b/src/core/lib/iomgr/tcp_posix.cc @@ -204,15 +204,13 @@ static void drop_uncovered(grpc_tcp* tcp) { GPR_ASSERT(old_count != 1); } -/* gRPC API considers a Write operation to be done the moment it clears ‘flow - control’ i.e., and not necessarily sent on the wire. This means that the - application MAY NOT call `grpc_completion_queue_next/pluck` in a timely - manner when its `Write()` API is acked. - - We need to ensure that the fd is 'covered' (i.e being monitored by some - polling thread and progress is made) and hence add it to a backup poller - here */ - +// gRPC API considers a Write operation to be done the moment it clears ‘flow +// control’ i.e., not necessarily sent on the wire. This means that the +// application MIGHT not call `grpc_completion_queue_next/pluck` in a timely +// manner when its `Write()` API is acked. +// +// We need to ensure that the fd is 'covered' (i.e being monitored by some +// polling thread and progress is made) and hence add it to a backup poller here static void cover_self(grpc_tcp* tcp) { backup_poller* p; gpr_atm old_count = |