aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/lib/http
diff options
context:
space:
mode:
authorGravatar yang-g <yangg@google.com>2017-03-01 11:36:23 -0800
committerGravatar yang-g <yangg@google.com>2017-03-01 11:36:23 -0800
commit5838dbffebf57ebcbf40bc8e7397d9be1ffd076d (patch)
tree03121817c74a1fe55a76da83f89d0572a33f6d93 /src/core/lib/http
parent4b290e9ee35bf5fb6334312e4da12fdb4b673445 (diff)
Return an error when the HTTP first line or header is longer than 4K
Diffstat (limited to 'src/core/lib/http')
-rw-r--r--src/core/lib/http/parser.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/core/lib/http/parser.c b/src/core/lib/http/parser.c
index 2f84adc187..b9c56c103c 100644
--- a/src/core/lib/http/parser.c
+++ b/src/core/lib/http/parser.c
@@ -284,9 +284,9 @@ static grpc_error *addbyte(grpc_http_parser *parser, uint8_t byte,
case GRPC_HTTP_HEADERS:
if (parser->cur_line_length >= GRPC_HTTP_PARSER_MAX_HEADER_LENGTH) {
if (grpc_http1_trace)
- gpr_log(GPR_ERROR, "HTTP client max line length (%d) exceeded",
+ gpr_log(GPR_ERROR, "HTTP header max line length (%d) exceeded",
GRPC_HTTP_PARSER_MAX_HEADER_LENGTH);
- return GRPC_ERROR_NONE;
+ return GRPC_ERROR_CREATE("HTTP header max line length exceeded");
}
parser->cur_line[parser->cur_line_length] = byte;
parser->cur_line_length++;