diff options
author | vjpai <vpai@google.com> | 2015-09-24 17:55:18 -0700 |
---|---|---|
committer | vjpai <vpai@google.com> | 2015-09-24 17:55:18 -0700 |
commit | 9839d285cd39d3fd2a16f3393f33e72f1e6b645b (patch) | |
tree | 636d1e349d23d4361d2313539a9324888b6e46c7 /src/core/iomgr | |
parent | 50d653476d4d49978ee3586b1b46b0f247eb60e5 (diff) |
Move block_annotate from iomgr to support since it's used in other
core places besides iomgr
Diffstat (limited to 'src/core/iomgr')
-rw-r--r-- | src/core/iomgr/block_annotate.h | 44 | ||||
-rw-r--r-- | src/core/iomgr/pollset_multipoller_with_epoll.c | 10 | ||||
-rw-r--r-- | src/core/iomgr/pollset_multipoller_with_poll_posix.c | 6 | ||||
-rw-r--r-- | src/core/iomgr/pollset_posix.c | 6 | ||||
-rw-r--r-- | src/core/iomgr/resolve_address_posix.c | 10 | ||||
-rw-r--r-- | src/core/iomgr/resolve_address_windows.c | 6 |
6 files changed, 19 insertions, 63 deletions
diff --git a/src/core/iomgr/block_annotate.h b/src/core/iomgr/block_annotate.h deleted file mode 100644 index c962da0a89..0000000000 --- a/src/core/iomgr/block_annotate.h +++ /dev/null @@ -1,44 +0,0 @@ -/* - * - * Copyright 2015, Google Inc. - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are - * met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above - * copyright notice, this list of conditions and the following disclaimer - * in the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Google Inc. nor the names of its - * contributors may be used to endorse or promote products derived from - * this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - * - */ - -#ifndef GRPC_INTERNAL_CORE_IOMGR_BLOCK_ANNOTATE_H -#define GRPC_INTERNAL_CORE_IOMGR_BLOCK_ANNOTATE_H - -/* These annotations identify the beginning and end of regions where - the code may block for reasons other than synchronization functions. - These include poll, epoll, and getaddrinfo. */ - -#define GRPC_IOMGR_START_BLOCKING_REGION do {} while (0) -#define GRPC_IOMGR_END_BLOCKING_REGION do {} while (0) - -#endif /* GRPC_INTERNAL_CORE_IOMGR_BLOCK_ANNOTATE_H */ diff --git a/src/core/iomgr/pollset_multipoller_with_epoll.c b/src/core/iomgr/pollset_multipoller_with_epoll.c index 39746d501b..65d1517291 100644 --- a/src/core/iomgr/pollset_multipoller_with_epoll.c +++ b/src/core/iomgr/pollset_multipoller_with_epoll.c @@ -41,8 +41,8 @@ #include <sys/epoll.h> #include <unistd.h> -#include "src/core/iomgr/block_annotate.h" #include "src/core/iomgr/fd_posix.h" +#include "src/core/support/block_annotate.h" #include <grpc/support/alloc.h> #include <grpc/support/log.h> @@ -181,9 +181,9 @@ static void multipoll_with_epoll_pollset_maybe_work( pfds[1].events = POLLIN; pfds[1].revents = 0; - GRPC_IOMGR_START_BLOCKING_REGION; + GRPC_SCHEDULING_START_BLOCKING_REGION; poll_rv = grpc_poll_function(pfds, 2, timeout_ms); - GRPC_IOMGR_END_BLOCKING_REGION; + GRPC_SCHEDULING_END_BLOCKING_REGION; if (poll_rv < 0) { if (errno != EINTR) { @@ -197,9 +197,9 @@ static void multipoll_with_epoll_pollset_maybe_work( } if (pfds[1].revents) { do { - GRPC_IOMGR_START_BLOCKING_REGION; + GRPC_SCHEDULING_START_BLOCKING_REGION; ep_rv = epoll_wait(h->epoll_fd, ep_ev, GRPC_EPOLL_MAX_EVENTS, 0); - GRPC_IOMGR_END_BLOCKING_REGION; + GRPC_SCHEDULING_END_BLOCKING_REGION; if (ep_rv < 0) { if (errno != EINTR) { gpr_log(GPR_ERROR, "epoll_wait() failed: %s", strerror(errno)); diff --git a/src/core/iomgr/pollset_multipoller_with_poll_posix.c b/src/core/iomgr/pollset_multipoller_with_poll_posix.c index 0b12aaca6d..75bba8214d 100644 --- a/src/core/iomgr/pollset_multipoller_with_poll_posix.c +++ b/src/core/iomgr/pollset_multipoller_with_poll_posix.c @@ -42,9 +42,9 @@ #include <stdlib.h> #include <string.h> -#include "src/core/iomgr/block_annotate.h" #include "src/core/iomgr/fd_posix.h" #include "src/core/iomgr/iomgr_internal.h" +#include "src/core/support/block_annotate.h" #include <grpc/support/alloc.h> #include <grpc/support/log.h> #include <grpc/support/useful.h> @@ -146,9 +146,9 @@ static void multipoll_with_poll_pollset_maybe_work( POLLOUT, &watchers[i]); } - GRPC_IOMGR_START_BLOCKING_REGION; + GRPC_SCHEDULING_START_BLOCKING_REGION; r = grpc_poll_function(pfds, pfd_count, timeout); - GRPC_IOMGR_END_BLOCKING_REGION; + GRPC_SCHEDULING_END_BLOCKING_REGION; for (i = 1; i < pfd_count; i++) { grpc_fd_end_poll(&watchers[i], pfds[i].revents & POLLIN, diff --git a/src/core/iomgr/pollset_posix.c b/src/core/iomgr/pollset_posix.c index cfdfbcf606..7d5340140c 100644 --- a/src/core/iomgr/pollset_posix.c +++ b/src/core/iomgr/pollset_posix.c @@ -43,11 +43,11 @@ #include <unistd.h> #include "src/core/iomgr/alarm_internal.h" -#include "src/core/iomgr/block_annotate.h" #include "src/core/iomgr/fd_posix.h" #include "src/core/iomgr/iomgr_internal.h" #include "src/core/iomgr/socket_utils_posix.h" #include "src/core/profiling/timers.h" +#include "src/core/support/block_annotate.h" #include <grpc/support/alloc.h> #include <grpc/support/log.h> #include <grpc/support/thd.h> @@ -454,9 +454,9 @@ static void basic_pollset_maybe_work(grpc_pollset *pollset, /* poll fd count (argument 2) is shortened by one if we have no events to poll on - such that it only includes the kicker */ - GRPC_IOMGR_START_BLOCKING_REGION; + GRPC_SCHEDULING_START_BLOCKING_REGION; r = grpc_poll_function(pfd, nfds, timeout); - GRPC_IOMGR_END_BLOCKING_REGION; + GRPC_SCHEDULING_END_BLOCKING_REGION; GRPC_TIMER_MARK(GRPC_PTAG_POLL_FINISHED, r); if (fd) { diff --git a/src/core/iomgr/resolve_address_posix.c b/src/core/iomgr/resolve_address_posix.c index e7ebe3a2e6..00b7423eab 100644 --- a/src/core/iomgr/resolve_address_posix.c +++ b/src/core/iomgr/resolve_address_posix.c @@ -41,9 +41,9 @@ #include <sys/un.h> #include <string.h> -#include "src/core/iomgr/block_annotate.h" #include "src/core/iomgr/iomgr_internal.h" #include "src/core/iomgr/sockaddr_utils.h" +#include "src/core/support/block_annotate.h" #include "src/core/support/string.h" #include <grpc/support/alloc.h> #include <grpc/support/host_port.h> @@ -104,18 +104,18 @@ grpc_resolved_addresses *grpc_blocking_resolve_address( hints.ai_socktype = SOCK_STREAM; /* stream socket */ hints.ai_flags = AI_PASSIVE; /* for wildcard IP address */ - GRPC_IOMGR_START_BLOCKING_REGION; + GRPC_SCHEDULING_START_BLOCKING_REGION; s = getaddrinfo(host, port, &hints, &result); - GRPC_IOMGR_END_BLOCKING_REGION; + GRPC_SCHEDULING_END_BLOCKING_REGION; if (s != 0) { /* Retry if well-known service name is recognized */ char *svc[][2] = {{"http", "80"}, {"https", "443"}}; for (i = 0; i < GPR_ARRAY_SIZE(svc); i++) { if (strcmp(port, svc[i][0]) == 0) { - GRPC_IOMGR_START_BLOCKING_REGION; + GRPC_SCHEDULING_START_BLOCKING_REGION; s = getaddrinfo(host, svc[i][1], &hints, &result); - GRPC_IOMGR_END_BLOCKING_REGION; + GRPC_SCHEDULING_END_BLOCKING_REGION; break; } } diff --git a/src/core/iomgr/resolve_address_windows.c b/src/core/iomgr/resolve_address_windows.c index e9297a7895..5e63df9f66 100644 --- a/src/core/iomgr/resolve_address_windows.c +++ b/src/core/iomgr/resolve_address_windows.c @@ -40,9 +40,9 @@ #include <sys/types.h> #include <string.h> -#include "src/core/iomgr/block_annotate.h" #include "src/core/iomgr/iomgr_internal.h" #include "src/core/iomgr/sockaddr_utils.h" +#include "src/core/support/block_annotate.h" #include "src/core/support/string.h" #include <grpc/support/alloc.h> #include <grpc/support/host_port.h> @@ -89,9 +89,9 @@ grpc_resolved_addresses *grpc_blocking_resolve_address( hints.ai_socktype = SOCK_STREAM; /* stream socket */ hints.ai_flags = AI_PASSIVE; /* for wildcard IP address */ - GRPC_IOMGR_START_BLOCKING_REGION; + GRPC_SCHEDULING_START_BLOCKING_REGION; s = getaddrinfo(host, port, &hints, &result); - GRPC_IOMGR_END_BLOCKING_REGION; + GRPC_SCHEDULING_END_BLOCKING_REGION; if (s != 0) { gpr_log(GPR_ERROR, "getaddrinfo: %s", gai_strerror(s)); goto done; |