diff options
| author |  Muxi Yan <mxyan@google.com> | 2017-06-23 17:05:54 -0700 |
|---|---|---|
| committer | Muxi Yan <mxyan@google.com> | 2017-06-23 17:05:54 -0700 |
| commit | c7208282aeb2140655f8d4b80335f6945a256a42 (patch) | |
| tree | 39ab513a060741721140a2e636ca98ef5fb450a1 /src/core/ext/transport | |
| parent | 275e392449ad4c366e65911a4d3b803f5bd840e5 (diff) | |
Add comment to explain the added lines and disable debugging log
Diffstat (limited to 'src/core/ext/transport')
| -rw-r--r-- | src/core/ext/transport/cronet/transport/cronet_transport.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/core/ext/transport/cronet/transport/cronet_transport.c b/src/core/ext/transport/cronet/transport/cronet_transport.c index 380146fece..498b444001 100644 --- a/src/core/ext/transport/cronet/transport/cronet_transport.c +++ b/src/core/ext/transport/cronet/transport/cronet_transport.c @@ -47,7 +47,7 @@ } while (0) /* TODO (makdharma): Hook up into the wider tracing mechanism */ -int grpc_cronet_trace = 1; +int grpc_cronet_trace = 0; enum e_op_result { ACTION_TAKEN_WITH_CALLBACK, @@ -797,8 +797,10 @@ static bool op_can_be_run(grpc_transport_stream_op_batch *curr_op, CRONET_LOG(GPR_DEBUG, "Because"); result = false; } - /* If cancelled, we need to wait for the cancel callback (if call is already - * started) */ + /* ON_COMPLETE can be processed if one of the following conditions is met: + * 1. the stream failed + * 2. the stream is cancelled, and the callback is received, or + * 3. the stream is cancelled, and the stream is never started */ if (op_id == OP_ON_COMPLETE && !(stream_state->state_callback_received[OP_FAILED] || stream_state->state_callback_received[OP_CANCELED] || |