diff options
author | David Garcia Quintas <dgq@google.com> | 2016-09-12 23:04:35 -0700 |
---|---|---|
committer | David Garcia Quintas <dgq@google.com> | 2016-09-12 23:04:35 -0700 |
commit | 6cc44fcf3ab68d55eadec5590e35b9268cc2d6a6 (patch) | |
tree | 7065ff358b6e049ae622f85bd5b0a95dc1aba1c2 /src/core/ext/lb_policy | |
parent | ebe7c176133f237f5b3df1bc12fdfb6fd692b25c (diff) |
PR comments
Diffstat (limited to 'src/core/ext/lb_policy')
-rw-r--r-- | src/core/ext/lb_policy/grpclb/grpclb.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/src/core/ext/lb_policy/grpclb/grpclb.c b/src/core/ext/lb_policy/grpclb/grpclb.c index ad070e458a..7fdc97dc3d 100644 --- a/src/core/ext/lb_policy/grpclb/grpclb.c +++ b/src/core/ext/lb_policy/grpclb/grpclb.c @@ -722,13 +722,12 @@ static int glb_pick(grpc_exec_ctx *exec_ctx, grpc_lb_policy *pol, glb_lb_policy *glb_policy = (glb_lb_policy *)pol; if (pick_args->lb_token_mdelem_storage == NULL) { - /* TODO(dgq): should this be an assert? If storage is NULL, something has - * gone very wrong at the client channel filter */ - gpr_log(GPR_ERROR, - "No mdelem storage for the LB token. Load reporting won't work " - "without it. Failing"); *target = NULL; - grpc_exec_ctx_sched(exec_ctx, on_complete, GRPC_ERROR_NONE, NULL); + grpc_exec_ctx_sched( + exec_ctx, on_complete, + GRPC_ERROR_CREATE("No mdelem storage for the LB token. Load reporting " + "won't work without it. Failing"), + NULL); return 1; } |