diff options
| author |  Yash Tibrewal <yashkt@google.com> | 2018-09-21 16:50:14 -0700 |
|---|---|---|
| committer | Yash Tibrewal <yashkt@google.com> | 2018-09-21 16:50:14 -0700 |
| commit | cd1992bc04f01279be9e00226633fa5984713cd6 (patch) | |
| tree | 47905783c4e9fda7522711b78d610791098b444d /src/core/ext/filters/message_size | |
| parent | a12740f0ae20cbead056df8c2231052c218d0d02 (diff) | |
Add comment
Diffstat (limited to 'src/core/ext/filters/message_size')
| -rw-r--r-- | src/core/ext/filters/message_size/message_size_filter.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/core/ext/filters/message_size/message_size_filter.cc b/src/core/ext/filters/message_size/message_size_filter.cc index 6a3e14aa13..2d3b16d992 100644 --- a/src/core/ext/filters/message_size/message_size_filter.cc +++ b/src/core/ext/filters/message_size/message_size_filter.cc @@ -152,6 +152,11 @@ static void recv_message_ready(void* user_data, grpc_error* error) { grpc_closure* closure = calld->next_recv_message_ready; calld->next_recv_message_ready = nullptr; if (calld->seen_recv_trailing_metadata) { + /* We might potentially see another RECV_MESSAGE op. In that case, we do not + * want to run the recv_trailing_metadata_ready closure again. The newer + * RECV_MESSAGE op cannot cause any errors since the transport has already + * invoked the recv_trailing_metadata_ready closure and all further + * RECV_MESSAGE ops will get null payloads. */ calld->seen_recv_trailing_metadata = false; GRPC_CALL_COMBINER_START(calld->call_combiner, &calld->recv_trailing_metadata_ready, |