aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/ext/filters/http
diff options
context:
space:
mode:
authorGravatar ncteisen <ncteisen@gmail.com>2018-06-11 11:36:19 -0700
committerGravatar ncteisen <ncteisen@gmail.com>2018-06-13 10:36:32 -0700
commitf82e28fb6f6d94f37bc646c1899f2e412e4b949e (patch)
tree73eb167b910479177c2c976616a726fe7d7290b0 /src/core/ext/filters/http
parentfeead68be9b85a731088e73abaf756d80da71b93 (diff)
Clean up use of GRPC_ARG_INTEGER
Diffstat (limited to 'src/core/ext/filters/http')
-rw-r--r--src/core/ext/filters/http/client/http_client_filter.cc20
1 files changed, 8 insertions, 12 deletions
diff --git a/src/core/ext/filters/http/client/http_client_filter.cc b/src/core/ext/filters/http/client/http_client_filter.cc
index 6fa9a251f3..2be37c7d13 100644
--- a/src/core/ext/filters/http/client/http_client_filter.cc
+++ b/src/core/ext/filters/http/client/http_client_filter.cc
@@ -455,18 +455,14 @@ static grpc_mdelem scheme_from_args(const grpc_channel_args* channel_args) {
return GRPC_MDELEM_SCHEME_HTTP;
}
-static size_t max_payload_size_from_args(const grpc_channel_args* args) {
- if (args != nullptr) {
- for (size_t i = 0; i < args->num_args; ++i) {
- if (0 == strcmp(args->args[i].key, GRPC_ARG_MAX_PAYLOAD_SIZE_FOR_GET)) {
- if (args->args[i].type != GRPC_ARG_INTEGER) {
- gpr_log(GPR_ERROR, "%s: must be an integer",
- GRPC_ARG_MAX_PAYLOAD_SIZE_FOR_GET);
- } else {
- return static_cast<size_t>(args->args[i].value.integer);
- }
- }
- }
+static size_t max_payload_size_from_args(
+ const grpc_channel_args* channel_args) {
+ if (channel_args != nullptr) {
+ const grpc_arg* arg =
+ grpc_channel_args_find(channel_args, GRPC_ARG_MAX_PAYLOAD_SIZE_FOR_GET);
+ // TODO(mark): is 0 a correct minimum for this value?
+ return grpc_channel_arg_get_integer(
+ arg, {kMaxPayloadSizeForGet, 0, kMaxPayloadSizeForGet});
}
return kMaxPayloadSizeForGet;
}