diff options
author | David Garcia Quintas <dgq@google.com> | 2018-02-01 13:44:55 -0800 |
---|---|---|
committer | David Garcia Quintas <dgq@google.com> | 2018-02-01 13:44:55 -0800 |
commit | e53d6b3f6034a5bbf72e3ad4438f834191235323 (patch) | |
tree | a0062eb86f8123fc70d2372da7eca1ac9c52268a /src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc | |
parent | 052c07d49093e57eb599217954cb01f6c0bffa1a (diff) |
PR comments
Diffstat (limited to 'src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc')
-rw-r--r-- | src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc b/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc index eabb4006d9..ecd6116ad1 100644 --- a/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc +++ b/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc @@ -92,8 +92,7 @@ typedef struct { grpc_core::ManualConstructor<grpc_core::BackOff> backoff; /** min resolution period. Max one resolution will happen per period */ grpc_millis min_time_between_resolutions; - /** when was the last resolution? If no resolution has happened yet, equals - * gpr_inf_past() */ + /** when was the last resolution? -1 if no resolution has happened yet */ grpc_millis last_resolution_timestamp; /** currently resolving addresses */ grpc_lb_addresses* lb_addresses; @@ -147,7 +146,7 @@ static void dns_ares_on_next_resolution_timer_locked(void* arg, r->have_next_resolution_timer = false; if (error == GRPC_ERROR_NONE) { if (!r->resolving) { - dns_ares_maybe_start_resolving_locked(r); + dns_ares_start_resolving_locked(r); } } GRPC_RESOLVER_UNREF(&r->base, "next_resolution_timer"); @@ -305,7 +304,7 @@ static void dns_ares_next_locked(grpc_resolver* resolver, r->target_result = target_result; if (r->resolved_version == 0 && !r->resolving) { r->backoff->Reset(); - dns_ares_start_resolving_locked(r); + dns_ares_maybe_start_resolving_locked(r); } else { dns_ares_maybe_finish_next_locked(r); } @@ -379,7 +378,6 @@ static void dns_ares_destroy(grpc_resolver* gr) { gpr_free(r); } - static grpc_resolver* dns_ares_create(grpc_resolver_args* args, const char* default_port) { /* Get name from args. */ |