diff options
author | Mark D. Roth <roth@google.com> | 2018-04-27 10:47:55 -0700 |
---|---|---|
committer | Mark D. Roth <roth@google.com> | 2018-04-27 10:49:13 -0700 |
commit | d0bb3c88c8dde755f83cc51059996ad8396c82aa (patch) | |
tree | e13dcdd08f8114173f76e9ff411c2351b832dfc4 /src/core/ext/filters/client_channel/lb_policy/subchannel_list.h | |
parent | 8d51cabcb9e67928739650ac2e78a748d8e5be9d (diff) |
Remove SetConnectedSubchannelFromLocked().
Diffstat (limited to 'src/core/ext/filters/client_channel/lb_policy/subchannel_list.h')
-rw-r--r-- | src/core/ext/filters/client_channel/lb_policy/subchannel_list.h | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/src/core/ext/filters/client_channel/lb_policy/subchannel_list.h b/src/core/ext/filters/client_channel/lb_policy/subchannel_list.h index bad50c461c..276a2f08a1 100644 --- a/src/core/ext/filters/client_channel/lb_policy/subchannel_list.h +++ b/src/core/ext/filters/client_channel/lb_policy/subchannel_list.h @@ -89,20 +89,6 @@ class SubchannelData { return connected_subchannel_.get(); } -// FIXME: remove - // Used to set the connected subchannel in cases where we are retaining a - // subchannel from a previous subchannel list. This is slightly more - // efficient than getting the connected subchannel from the subchannel, - // because that approach requires the use of a mutex, whereas this one - // only mutates a refcount. - // TODO(roth): This method is a bit of a hack and is used only in - // pick_first. When we have time, find a way to remove this, possibly - // by making pick_first work more like round_robin. - void SetConnectedSubchannelFromLocked(SubchannelData* other) { - GPR_ASSERT(subchannel_ == other->subchannel_); - connected_subchannel_ = other->connected_subchannel_; // Adds ref. - } - // Synchronously checks the subchannel's connectivity state. // Must not be called while there is a connectivity notification // pending (i.e., between calling StartConnectivityWatchLocked() or |