diff options
author | 2018-07-12 17:24:48 -0700 | |
---|---|---|
committer | 2018-07-12 17:32:04 -0700 | |
commit | 25082c5fc47d0b337657476a0fa7ce989b9712ef (patch) | |
tree | cee9962e66cf34696d9b9b004c75c83e0d9a7131 /src/core/ext/filters/client_channel/lb_policy.h | |
parent | 018498a06be9188bda95b5753e2aa93db2b5a28f (diff) |
Reviewer feedback
Diffstat (limited to 'src/core/ext/filters/client_channel/lb_policy.h')
-rw-r--r-- | src/core/ext/filters/client_channel/lb_policy.h | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/core/ext/filters/client_channel/lb_policy.h b/src/core/ext/filters/client_channel/lb_policy.h index 0c5fd2ad9c..e756c89208 100644 --- a/src/core/ext/filters/client_channel/lb_policy.h +++ b/src/core/ext/filters/client_channel/lb_policy.h @@ -29,7 +29,6 @@ #include "src/core/lib/gprpp/ref_counted_ptr.h" #include "src/core/lib/iomgr/combiner.h" #include "src/core/lib/iomgr/polling_entity.h" -#include "src/core/lib/json/json.h" #include "src/core/lib/transport/connectivity_state.h" extern grpc_core::DebugOnlyTraceFlag grpc_trace_lb_policy_refcount; @@ -145,6 +144,14 @@ class LoadBalancingPolicy /// consider whether this method is still needed. virtual void ExitIdleLocked() GRPC_ABSTRACT; + /// populates child_subchannels and child_channels with the uuids of this + /// LB policy's referenced children. This is not invoked from the + /// client_channel's combiner. The implementation is responsible for + /// providing its own synchronization. + virtual void FillChildRefsForChannelz(ChildRefsList* child_subchannels, + ChildRefsList* child_channels) + GRPC_ABSTRACT; + void Orphan() override { // Invoke ShutdownAndUnrefLocked() inside of the combiner. GRPC_CLOSURE_SCHED( @@ -159,13 +166,6 @@ class LoadBalancingPolicy request_reresolution_ = request_reresolution; } - /// populates child_subchannels and child_channels with the uuids of this - /// LB policies referenced children. This is not invoked from the - /// client_channel's combiner. It has its own synchronization. This is - /// not abstract, since the behavior is the same for all LB policies. - void FillChildRefsForChannelz(ChildRefsList* child_subchannels, - ChildRefsList* child_channels); - grpc_pollset_set* interested_parties() const { return interested_parties_; } GRPC_ABSTRACT_BASE_CLASS |