aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/ext/filters/client_channel/http_connect_handshaker.cc
diff options
context:
space:
mode:
authorGravatar Noah Eisen <ncteisen@google.com>2018-02-14 07:36:33 -0800
committerGravatar Noah Eisen <ncteisen@google.com>2018-02-14 07:36:33 -0800
commit49cab8f4c6e7642a376eb1ec835a4790a53d19a3 (patch)
treeb2108b1253311031e7e1d50a4a502c43c0ec90eb /src/core/ext/filters/client_channel/http_connect_handshaker.cc
parent2ee8cb998bf3fb607a74bdf69fdc873a4f6aa582 (diff)
Fix handshaker crash
Diffstat (limited to 'src/core/ext/filters/client_channel/http_connect_handshaker.cc')
-rw-r--r--src/core/ext/filters/client_channel/http_connect_handshaker.cc3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/core/ext/filters/client_channel/http_connect_handshaker.cc b/src/core/ext/filters/client_channel/http_connect_handshaker.cc
index 6bb4cefe73..88bcc03a3c 100644
--- a/src/core/ext/filters/client_channel/http_connect_handshaker.cc
+++ b/src/core/ext/filters/client_channel/http_connect_handshaker.cc
@@ -254,7 +254,8 @@ static void http_connect_handshaker_do_handshake(
// If not found, invoke on_handshake_done without doing anything.
const grpc_arg* arg =
grpc_channel_args_find(args->args, GRPC_ARG_HTTP_CONNECT_SERVER);
- if (arg == nullptr) {
+ if (arg == nullptr || arg->type != GRPC_ARG_STRING) {
+ gpr_log(GPR_INFO, "HTTP CONNECT channel arg not found or invalid");
// Set shutdown to true so that subsequent calls to
// http_connect_handshaker_shutdown() do nothing.
gpr_mu_lock(&handshaker->mu);