aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/ext/filters/client_channel/client_channel_channelz.h
diff options
context:
space:
mode:
authorGravatar ncteisen <ncteisen@gmail.com>2018-07-03 11:25:41 -0700
committerGravatar Noah Eisen <ncteisen@google.com>2018-07-06 15:34:55 -0700
commitcaa85b2a4340c54904a41f1c2fc1ffc17e7f8dbb (patch)
treee32eacdf53c20aa827889cc7db93989a37329feb /src/core/ext/filters/client_channel/client_channel_channelz.h
parentc9c1feffca295ea9b6232c40d6ac09c5b82343d5 (diff)
Reviewer feedback
Diffstat (limited to 'src/core/ext/filters/client_channel/client_channel_channelz.h')
-rw-r--r--src/core/ext/filters/client_channel/client_channel_channelz.h17
1 files changed, 9 insertions, 8 deletions
diff --git a/src/core/ext/filters/client_channel/client_channel_channelz.h b/src/core/ext/filters/client_channel/client_channel_channelz.h
index a3f8b07fd6..cf3ef7b6f2 100644
--- a/src/core/ext/filters/client_channel/client_channel_channelz.h
+++ b/src/core/ext/filters/client_channel/client_channel_channelz.h
@@ -31,8 +31,8 @@ namespace channelz {
// functionality like querying for connectivity_state and subchannel data.
class ClientChannelNode : public ChannelNode {
public:
- ClientChannelNode(grpc_channel* channel, size_t channel_tracer_max_nodes);
- virtual ~ClientChannelNode() {}
+ static RefCountedPtr<ChannelNode> MakeClientChannelNode(
+ grpc_channel* channel, size_t channel_tracer_max_nodes);
// Override this functionality since client_channels have a notion of
// channel connectivity.
@@ -40,17 +40,18 @@ class ClientChannelNode : public ChannelNode {
// Helper to create a channel arg to ensure this type of ChannelNode is
// created.
- static grpc_arg CreateArg();
+ static grpc_arg CreateChannelArg();
+
+ protected:
+ GPRC_ALLOW_CLASS_TO_USE_NON_PUBLIC_DELETE
+ GPRC_ALLOW_CLASS_TO_USE_NON_PUBLIC_NEW
+ ClientChannelNode(grpc_channel* channel, size_t channel_tracer_max_nodes);
+ virtual ~ClientChannelNode() {}
private:
grpc_channel_element* client_channel_;
};
-RefCountedPtr<ChannelNode> MakeClientChannelNode(
- grpc_channel* channel, size_t channel_tracer_max_nodes);
-
-grpc_arg BlahBlah();
-
} // namespace channelz
} // namespace grpc_core