diff options
author | Yash Tibrewal <yashkt@google.com> | 2018-04-30 17:50:22 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-04-30 17:50:22 -0700 |
commit | e5cb0469f2f8422a4b0d283cd647e8d31b7064fb (patch) | |
tree | a8d6d943c334c12085b18cdb0b6481bf7734082a /src/core/ext/filters/client_channel/client_channel.cc | |
parent | bdc523af68d4c9262aa6e37e3e82b920ec4b5f31 (diff) | |
parent | 446d1ea6807b1b33346e26e446b9df2a94d0276e (diff) |
Merge pull request #15236 from yashykt/runcomment
Message about the watcher_timer_init closure requiring immediate exec
Diffstat (limited to 'src/core/ext/filters/client_channel/client_channel.cc')
-rw-r--r-- | src/core/ext/filters/client_channel/client_channel.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/core/ext/filters/client_channel/client_channel.cc b/src/core/ext/filters/client_channel/client_channel.cc index 875af66168..80a647fa94 100644 --- a/src/core/ext/filters/client_channel/client_channel.cc +++ b/src/core/ext/filters/client_channel/client_channel.cc @@ -3252,6 +3252,8 @@ static void watch_connectivity_state_locked(void* arg, external_connectivity_watcher* found = nullptr; if (w->state != nullptr) { external_connectivity_watcher_list_append(w->chand, w); + // An assumption is being made that the closure is scheduled on the exec ctx + // scheduler and that GRPC_CLOSURE_RUN would run the closure immediately. GRPC_CLOSURE_RUN(w->watcher_timer_init, GRPC_ERROR_NONE); GRPC_CLOSURE_INIT(&w->my_closure, on_external_watch_complete_locked, w, grpc_combiner_scheduler(w->chand->combiner)); |