diff options
author | ncteisen <ncteisen@gmail.com> | 2018-02-14 17:34:05 -0800 |
---|---|---|
committer | ncteisen <ncteisen@gmail.com> | 2018-02-14 17:34:05 -0800 |
commit | bf323a985f0a6f2ab81fe07a790959aee743791d (patch) | |
tree | 0588ea5b13d4dc4535ac7c860a71ceddb673c924 /src/core/ext/filters/client_channel/client_channel.cc | |
parent | 6f374ea2fef54f0cf12af936bc9a30896830152f (diff) |
Use grpc_channel_arg_get_string when appropriate
Diffstat (limited to 'src/core/ext/filters/client_channel/client_channel.cc')
-rw-r--r-- | src/core/ext/filters/client_channel/client_channel.cc | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/src/core/ext/filters/client_channel/client_channel.cc b/src/core/ext/filters/client_channel/client_channel.cc index 7b04bdc0dd..aec13f080a 100644 --- a/src/core/ext/filters/client_channel/client_channel.cc +++ b/src/core/ext/filters/client_channel/client_channel.cc @@ -405,10 +405,7 @@ static void on_resolver_result_changed_locked(void* arg, grpc_error* error) { const char* lb_policy_name = nullptr; const grpc_arg* channel_arg = grpc_channel_args_find( chand->resolver_result, GRPC_ARG_LB_POLICY_NAME); - if (channel_arg != nullptr) { - GPR_ASSERT(channel_arg->type == GRPC_ARG_STRING); - lb_policy_name = channel_arg->value.string; - } + const char* lb_policy_name = grpc_channel_arg_get_string(channel_arg); // Special case: If at least one balancer address is present, we use // the grpclb policy, regardless of what the resolver actually specified. channel_arg = @@ -475,16 +472,17 @@ static void on_resolver_result_changed_locked(void* arg, grpc_error* error) { // Find service config. channel_arg = grpc_channel_args_find(chand->resolver_result, GRPC_ARG_SERVICE_CONFIG); - if (channel_arg != nullptr && channel_arg->type == GRPC_ARG_STRING) { - service_config_json = gpr_strdup(channel_arg->value.string); + service_config_json = + gpr_strdup(grpc_channel_arg_get_string(channel_arg)); + if (service_config_json != nullptr) { grpc_service_config* service_config = grpc_service_config_create(service_config_json); if (service_config != nullptr) { channel_arg = grpc_channel_args_find(chand->resolver_result, GRPC_ARG_SERVER_URI); - GPR_ASSERT(channel_arg != nullptr); - GPR_ASSERT(channel_arg->type == GRPC_ARG_STRING); - grpc_uri* uri = grpc_uri_parse(channel_arg->value.string, true); + const char* server_uri = grpc_channel_arg_get_string(channel_arg); + GPR_ASSERT(server_uri != nullptr); + grpc_uri* uri = grpc_uri_parse(server_uri, true); GPR_ASSERT(uri->path[0] != '\0'); service_config_parsing_state parsing_state; memset(&parsing_state, 0, sizeof(parsing_state)); |