aboutsummaryrefslogtreecommitdiffhomepage
path: root/include
diff options
context:
space:
mode:
authorGravatar Vijay Pai <vpai@google.com>2018-11-13 21:51:56 -0800
committerGravatar Vijay Pai <vpai@google.com>2018-11-30 04:13:40 -0800
commitfa45ffd4180511e0f11588847936741d68d0e6ff (patch)
treee2d18764b16c625c36b08be57e2b0fcd574cf147 /include
parent85128c7f4130178fa0d5fd4706e93fd8be7d64ff (diff)
Address reviewer comments
Diffstat (limited to 'include')
-rw-r--r--include/grpcpp/impl/codegen/client_callback.h15
1 files changed, 7 insertions, 8 deletions
diff --git a/include/grpcpp/impl/codegen/client_callback.h b/include/grpcpp/impl/codegen/client_callback.h
index 01a28a9e6f..49ceaf7ca2 100644
--- a/include/grpcpp/impl/codegen/client_callback.h
+++ b/include/grpcpp/impl/codegen/client_callback.h
@@ -96,7 +96,6 @@ namespace experimental {
// The user must implement this reactor interface with reactions to each event
// type that gets called by the library. An empty reaction is provided by
// default
-
class ClientBidiReactor {
public:
virtual ~ClientBidiReactor() {}
@@ -198,8 +197,8 @@ class ClientCallbackReaderWriterImpl
}
void StartCall() override {
- // This call initiates two batches
- // 1. Send initial metadata (unless corked)/recv initial metadata
+ // This call initiates two batches, each with a callback
+ // 1. Send initial metadata (unless corked) + recv initial metadata
// 2. Recv trailing metadata, on_completion callback
callbacks_outstanding_ = 2;
@@ -359,8 +358,8 @@ class ClientCallbackReaderImpl
}
void StartCall() override {
- // This call initiates two batches
- // 1. Send initial metadata (unless corked)/recv initial metadata
+ // This call initiates two batches, each with a callback
+ // 1. Send initial metadata (unless corked) + recv initial metadata
// 2. Recv trailing metadata, on_completion callback
callbacks_outstanding_ = 2;
@@ -472,9 +471,9 @@ class ClientCallbackWriterImpl
}
void StartCall() override {
- // This call initiates two batches
- // 1. Send initial metadata (unless corked)/recv initial metadata
- // 2. Recv message + trailing metadata, on_completion callback
+ // This call initiates two batches, each with a callback
+ // 1. Send initial metadata (unless corked) + recv initial metadata
+ // 2. Recv message + recv trailing metadata, on_completion callback
callbacks_outstanding_ = 2;
start_tag_.Set(call_.call(),