diff options
| author |  Sree Kuchibhotla <sreecha@users.noreply.github.com> | 2016-03-07 10:51:02 -0800 |
|---|---|---|
| committer | Sree Kuchibhotla <sreecha@users.noreply.github.com> | 2016-03-07 10:51:02 -0800 |
| commit | b0d1567e8ea9c4ed528e63df9a8649c953b4e349 (patch) | |
| tree | 1450889585f205a3840fa7afdf083954a1987224 /include | |
| parent | 6537ab9dc12607307338be1ab3c7b10b91e4a1f4 (diff) | |
Revert "Revert "Properly integrate async API with server-side cancellations.""
Diffstat (limited to 'include')
| -rw-r--r-- | include/grpc++/impl/codegen/completion_queue.h | 1 | ||||
| -rw-r--r-- | include/grpc++/impl/codegen/server_context.h | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/include/grpc++/impl/codegen/completion_queue.h b/include/grpc++/impl/codegen/completion_queue.h index 102831e1c9..928ab2db31 100644 --- a/include/grpc++/impl/codegen/completion_queue.h +++ b/include/grpc++/impl/codegen/completion_queue.h @@ -184,6 +184,7 @@ class CompletionQueue : private GrpcLibrary { bool Pluck(CompletionQueueTag* tag); /// Performs a single polling pluck on \a tag. + /// \warning Must not be mixed with calls to \a Next. void TryPluck(CompletionQueueTag* tag); grpc_completion_queue* cq_; // owned diff --git a/include/grpc++/impl/codegen/server_context.h b/include/grpc++/impl/codegen/server_context.h index ad08b8210d..91ebe574b1 100644 --- a/include/grpc++/impl/codegen/server_context.h +++ b/include/grpc++/impl/codegen/server_context.h @@ -103,6 +103,9 @@ class ServerContext { void AddInitialMetadata(const grpc::string& key, const grpc::string& value); void AddTrailingMetadata(const grpc::string& key, const grpc::string& value); + // IsCancelled is always safe to call when using sync API + // When using async API, it is only safe to call IsCancelled after + // the AsyncNotifyWhenDone tag has been delivered bool IsCancelled() const; // Cancel the Call from the server. This is a best-effort API and depending on |