aboutsummaryrefslogtreecommitdiffhomepage
path: root/include
diff options
context:
space:
mode:
authorGravatar Yash Tibrewal <yashkt@google.com>2018-11-21 14:00:16 -0800
committerGravatar Yash Tibrewal <yashkt@google.com>2018-11-21 14:00:16 -0800
commit544f2a5abbee840c5b7a28b41e75b3ff5c0f3b60 (patch)
treef7c3ac085af296e7402ad26960d5bdc9b0944f96 /include
parent248e30467146efe8bc6f4f05140ae886d743c72d (diff)
Necessary change after #17219
Diffstat (limited to 'include')
-rw-r--r--include/grpcpp/impl/codegen/client_unary_call.h7
1 files changed, 6 insertions, 1 deletions
diff --git a/include/grpcpp/impl/codegen/client_unary_call.h b/include/grpcpp/impl/codegen/client_unary_call.h
index b1c80764f2..18ee5b34bf 100644
--- a/include/grpcpp/impl/codegen/client_unary_call.h
+++ b/include/grpcpp/impl/codegen/client_unary_call.h
@@ -75,7 +75,12 @@ class BlockingUnaryCallImpl {
"No message returned for unary request");
}
} else {
- GPR_CODEGEN_ASSERT(!status_.ok());
+ // Some of the ops failed. For example, this can happen if deserialization
+ // of the message fails. gRPC Core guarantees that the op
+ // GRPC_OP_RECV_STATUS_ON_CLIENT always succeeds, so status would still be
+ // filled.
+ // TODO(yashykt): If deserialization fails, but the status received is OK,
+ // then it might be a good idea to change the status to reflect this.
}
}
Status status() { return status_; }