diff options
author | Julien Boeuf <jboeuf@google.com> | 2015-08-17 13:23:05 -0700 |
---|---|---|
committer | Julien Boeuf <jboeuf@google.com> | 2015-08-17 13:23:05 -0700 |
commit | bc265583d6a1810289568d08a577f213bedcb577 (patch) | |
tree | bb6265c98fb5f8e93e777cc276c0c0d7dfc191a2 /include/grpc++ | |
parent | 8da211f638ebe36abe79aa068229799a536e4243 (diff) |
Addressing comments. Thanks Yang!
Diffstat (limited to 'include/grpc++')
-rw-r--r-- | include/grpc++/auth_metadata_processor.h | 7 | ||||
-rw-r--r-- | include/grpc++/server_credentials.h | 3 |
2 files changed, 7 insertions, 3 deletions
diff --git a/include/grpc++/auth_metadata_processor.h b/include/grpc++/auth_metadata_processor.h index 45030a6a45..db4beafeff 100644 --- a/include/grpc++/auth_metadata_processor.h +++ b/include/grpc++/auth_metadata_processor.h @@ -46,14 +46,17 @@ class AuthMetadataProcessor { virtual ~AuthMetadataProcessor() {} // If this method returns true, the Process function will be scheduled in - // a different thread as the one processing the call. + // a different thread from the one processing the call. virtual bool IsBlocking() const { return true; } // context is read/write: it contains the properties of the channel peer and // it is the job of the Process method to augment it with properties derived // from the passed-in auth_metadata. + // consumed_auth_metadata needs to be filled with metadata that has been + // consumed by the processor and will be removed from the call. + // Returns true if successful. virtual bool Process( - std::multimap<grpc::string, grpc::string>& auth_metadata, + const std::multimap<grpc::string, grpc::string>& auth_metadata, AuthContext* context, std::multimap<grpc::string, grpc::string>* consumed_auth_metadata) = 0; }; diff --git a/include/grpc++/server_credentials.h b/include/grpc++/server_credentials.h index d540b95e21..bcc335b7d5 100644 --- a/include/grpc++/server_credentials.h +++ b/include/grpc++/server_credentials.h @@ -56,7 +56,8 @@ class ServerCredentials { virtual int AddPortToServer(const grpc::string& addr, grpc_server* server) = 0; - // Has to be called before the server is started. + // This method is not thread-safe and has to be called before the server is + // started. The last call to this function wins. virtual void SetAuthMetadataProcessor( const std::shared_ptr<AuthMetadataProcessor>& processor) = 0; }; |