diff options
| author |  ncteisen <ncteisen@gmail.com> | 2017-12-08 10:49:31 -0800 |
|---|---|---|
| committer | ncteisen <ncteisen@gmail.com> | 2017-12-08 10:49:31 -0800 |
| commit | 6193c63dabf37023bd9a985f2db807f0551dd1ef (patch) | |
| tree | bebc3c29b04808dc122b52ab21d5bd3d69b3776a /include/grpc++ | |
| parent | 11f6780bfd4600398da1ccb6b7c624e6704e8aa5 (diff) | |
Reviewer feedback
Diffstat (limited to 'include/grpc++')
| -rw-r--r-- | include/grpc++/impl/codegen/call.h | 3 | ||||
| -rw-r--r-- | include/grpc++/impl/codegen/client_context.h | 2 |
2 files changed, 2 insertions, 3 deletions
diff --git a/include/grpc++/impl/codegen/call.h b/include/grpc++/impl/codegen/call.h index 73773f366a..e581049e7f 100644 --- a/include/grpc++/impl/codegen/call.h +++ b/include/grpc++/impl/codegen/call.h @@ -595,8 +595,7 @@ class CallOpClientRecvStatus { GRPC_SLICE_END_PTR(error_message_)), binary_error_details); client_context_->set_debug_error_string( - debug_error_string_ != nullptr ? grpc::string(debug_error_string_) - : ""); + debug_error_string_ != nullptr ? debug_error_string_ : ""); g_core_codegen_interface->grpc_slice_unref(error_message_); if (debug_error_string_ != nullptr) { g_core_codegen_interface->gpr_free((void*)debug_error_string_); diff --git a/include/grpc++/impl/codegen/client_context.h b/include/grpc++/impl/codegen/client_context.h index b06b1fa44f..61d97ce818 100644 --- a/include/grpc++/impl/codegen/client_context.h +++ b/include/grpc++/impl/codegen/client_context.h @@ -382,7 +382,7 @@ class ClientContext { friend class ::grpc::internal::BlockingUnaryCallImpl; // Used by friend class CallOpClientRecvStatus - void set_debug_error_string(grpc::string debug_error_string) { + void set_debug_error_string(const grpc::string& debug_error_string) { debug_error_string_ = debug_error_string; } |