diff options
| author |  David G. Quintas <dgq@google.com> | 2017-08-16 12:15:42 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2017-08-16 12:15:42 -0700 |
| commit | fe4c9216676435b2926cc6d9347bd013c07ab073 (patch) | |
| tree | 93f31709d8d2e4a4c9ed5b9fa6b187313dc68d82 | |
| parent | 27bb4d99e219c084a37cccac2aeb3c06041731e5 (diff) | |
| parent | bfd9d805a16266b34adbc1f51eaf59d523276027 (diff) | |
Merge pull request #12197 from dgquintas/detect_flakes_3
Fix handling of no new flakes
| -rw-r--r-- | tools/flakes/detect_flakes.py | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/tools/flakes/detect_flakes.py b/tools/flakes/detect_flakes.py index 32899074da..2aff4c0872 100644 --- a/tools/flakes/detect_flakes.py +++ b/tools/flakes/detect_flakes.py @@ -68,10 +68,13 @@ ORDER BY timestamp desc query_job = big_query_utils.sync_query_job(bq, 'grpc-testing', query) page = bq.jobs().getQueryResults( pageToken=None, **query_job['jobReference']).execute(num_retries=3) - testname_to_cols = {row['f'][0]['v']: - (row['f'][1]['v'], row['f'][2]['v'], row['f'][3]['v']) - for row in page['rows']} - return testname_to_cols + rows = page.get('rows') + if rows: + return {row['f'][0]['v']: + (row['f'][1]['v'], row['f'][2]['v'], row['f'][3]['v']) + for row in rows} + else: + return {} def get_new_flakes(): @@ -91,6 +94,8 @@ def main(): if new_flakes: print("Found {} new flakes:".format(len(new_flakes))) print_table(new_flakes) + else: + print("No new flakes found!") if __name__ == '__main__': |