aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Alex Polcyn <apolcyn@google.com>2016-12-06 04:00:05 +0000
committerGravatar Alex Polcyn <apolcyn@google.com>2016-12-06 04:00:05 +0000
commitfcf09ea42e0a4216292152b12514329ce49e7706 (patch)
tree61b3f91d32d9a272bed0cc9981bc45083257538d
parentdc74a4d58b229e6dc845dec2520a2b8379bb2263 (diff)
handle empty string for qps workers in driver and dont quit them on netperf
-rw-r--r--test/cpp/qps/driver.cc2
-rwxr-xr-xtools/run_tests/run_performance_tests.py7
2 files changed, 5 insertions, 4 deletions
diff --git a/test/cpp/qps/driver.cc b/test/cpp/qps/driver.cc
index ea0b38e8ad..22b2cd080d 100644
--- a/test/cpp/qps/driver.cc
+++ b/test/cpp/qps/driver.cc
@@ -101,7 +101,7 @@ static std::unordered_map<string, std::deque<int>> get_hosts_and_cores(
static deque<string> get_workers(const string& name) {
char* env = gpr_getenv(name.c_str());
- if (!env) return deque<string>();
+ if (!env || strlen(env) == 0) return deque<string>();
deque<string> out;
char* p = env;
diff --git a/tools/run_tests/run_performance_tests.py b/tools/run_tests/run_performance_tests.py
index 1d0c98fb69..5e6ff44f4f 100755
--- a/tools/run_tests/run_performance_tests.py
+++ b/tools/run_tests/run_performance_tests.py
@@ -464,9 +464,10 @@ for scenario in scenarios:
try:
for worker in scenario.workers:
worker.start()
- scenario_failures, resultset = jobset.run([scenario.jobspec,
- create_quit_jobspec(scenario.workers, remote_host=args.remote_driver_host)],
- newline_on_success=True, maxjobs=1)
+ jobs = [scenario.jobspec]
+ if len(scenario.workers) > 0:
+ jobs.append(create_quit_jobspec(scenario.workers, remote_host=args.remote_driver_host))
+ scenario_failures, resultset = jobset.run(jobs, newline_on_success=True, maxjobs=1)
total_scenario_failures += scenario_failures
merged_resultset = dict(itertools.chain(merged_resultset.iteritems(),
resultset.iteritems()))