aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Tobias Jungel <tobias.jungel@gmail.com>2018-01-24 09:08:05 +0100
committerGravatar Tobias Jungel <tobias.jungel@gmail.com>2018-02-16 12:42:05 +0100
commitf258b56f43dfa9c5d279b8d73000b087f2a390d2 (patch)
treec015ef6d39e4e45cf23b6627e15170ddde3c6c4d
parentb0d71823a0f031ad1c04be30f22653177139da0b (diff)
fix non-virtual-dtor
compiling with -Wnon-virtual-dtor works with this patch
-rw-r--r--include/grpcpp/impl/codegen/core_codegen_interface.h2
-rw-r--r--include/grpcpp/impl/codegen/grpc_library.h1
2 files changed, 3 insertions, 0 deletions
diff --git a/include/grpcpp/impl/codegen/core_codegen_interface.h b/include/grpcpp/impl/codegen/core_codegen_interface.h
index 64bc9efc12..d72f579c8e 100644
--- a/include/grpcpp/impl/codegen/core_codegen_interface.h
+++ b/include/grpcpp/impl/codegen/core_codegen_interface.h
@@ -36,6 +36,8 @@ namespace grpc {
/// \warning This interface should be considered internal and private.
class CoreCodegenInterface {
public:
+ virtual ~CoreCodegenInterface() = default;
+
/// Upon a failed assertion, log the error.
virtual void assert_fail(const char* failed_assertion, const char* file,
int line) = 0;
diff --git a/include/grpcpp/impl/codegen/grpc_library.h b/include/grpcpp/impl/codegen/grpc_library.h
index 684031f5d9..17c904d71a 100644
--- a/include/grpcpp/impl/codegen/grpc_library.h
+++ b/include/grpcpp/impl/codegen/grpc_library.h
@@ -25,6 +25,7 @@ namespace grpc {
class GrpcLibraryInterface {
public:
+ virtual ~GrpcLibraryInterface() = default;
virtual void init() = 0;
virtual void shutdown() = 0;
};