diff options
| author |  Sree Kuchibhotla <sreek@google.com> | 2018-07-27 16:19:17 -0700 |
|---|---|---|
| committer | Sree Kuchibhotla <sreek@google.com> | 2018-07-27 16:19:17 -0700 |
| commit | ece265778b077efa1c03e1de36b4e14446dd634a (patch) | |
| tree | cca5c6bc178ed3dd0ddb79d4ec6a6fcaae084241 | |
| parent | c2a22a1ab8e8221c95f8874668eb6260c1e171b4 (diff) | |
| parent | c01ec499125fab39cd1ec755bbdfdb042e08ac37 (diff) | |
Merge branch 'master' into rq-threads
| -rw-r--r-- | doc/statuscodes.md | 3 | ||||
| -rw-r--r-- | src/python/grpcio_tests/tests/unit/beta/_utilities_test.py | 1 | ||||
| -rwxr-xr-x | tools/internal_ci/linux/grpc_publish_packages.sh | 2 |
3 files changed, 5 insertions, 1 deletions
diff --git a/doc/statuscodes.md b/doc/statuscodes.md index f2df9e00de..06fbe5c8fe 100644 --- a/doc/statuscodes.md +++ b/doc/statuscodes.md @@ -38,6 +38,7 @@ situations in which they are generated. | Error parsing response proto | INTERNAL | Client| | Error parsing request proto | INTERNAL | Server| | Sent or received message was larger than configured limit | RESOURCE_EXHAUSTED | Both | +| Keepalive watchdog times out | INTERNAL | Both | The following status codes are never generated by the library: - INVALID_ARGUMENT @@ -47,3 +48,5 @@ The following status codes are never generated by the library: - ABORTED - OUT_OF_RANGE - DATA_LOSS + +Applications that may wish to [retry](https://github.com/grpc/proposal/blob/master/A6-client-retries.md) failed RPCs must decide which status codes on which to retry. As shown in the table above, the gRPC library can generate the same status code for different cases. Server applications can also return those same status codes. Therefore, there is no fixed list of status codes on which it is appropriate to retry in all applications. As a result, individual applications must make their own determination as to which status codes should cause an RPC to be retried. diff --git a/src/python/grpcio_tests/tests/unit/beta/_utilities_test.py b/src/python/grpcio_tests/tests/unit/beta/_utilities_test.py index aebee4da96..e042262796 100644 --- a/src/python/grpcio_tests/tests/unit/beta/_utilities_test.py +++ b/src/python/grpcio_tests/tests/unit/beta/_utilities_test.py @@ -41,6 +41,7 @@ class _Callback(object): return self._value +@unittest.skip('https://github.com/grpc/grpc/issues/16134') class ChannelConnectivityTest(unittest.TestCase): def test_lonely_channel_connectivity(self): diff --git a/tools/internal_ci/linux/grpc_publish_packages.sh b/tools/internal_ci/linux/grpc_publish_packages.sh index 1459364d57..ef943db7e1 100755 --- a/tools/internal_ci/linux/grpc_publish_packages.sh +++ b/tools/internal_ci/linux/grpc_publish_packages.sh @@ -28,7 +28,7 @@ BUILD_ID=${KOKORO_BUILD_ID:-$(uuidgen)} BUILD_BRANCH_NAME=master BUILD_GIT_COMMIT=${KOKORO_GIT_COMMIT:-unknown} BUILD_TIMESTAMP=$(date -Iseconds) -BUILD_RELPATH=$(date "+%Y/%m")/$BUILD_ID/ +BUILD_RELPATH=$(date "+%Y/%m")/$BUILD_GIT_COMMIT-$BUILD_ID/ GCS_ROOT=gs://packages.grpc.io/ GCS_ARCHIVE_PREFIX=archive/ |