aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Muxi Yan <mxyan@google.com>2018-11-14 16:34:58 -0800
committerGravatar Muxi Yan <mxyan@google.com>2018-11-14 16:34:58 -0800
commite023468e9a82a4338e30e57ab822c86406480b94 (patch)
treeac6a436cc409636f3492225cbd0250bf7a87e939
parentb22120f69601450d4cbdc6957f661ba7ec29ca3a (diff)
some nit fixes
-rw-r--r--src/objective-c/GRPCClient/GRPCCall.m2
-rw-r--r--src/objective-c/GRPCClient/GRPCCallOptions.m2
-rw-r--r--src/objective-c/GRPCClient/private/GRPCChannel.h2
3 files changed, 3 insertions, 3 deletions
diff --git a/src/objective-c/GRPCClient/GRPCCall.m b/src/objective-c/GRPCClient/GRPCCall.m
index 6de7bd8967..2a56514bdc 100644
--- a/src/objective-c/GRPCClient/GRPCCall.m
+++ b/src/objective-c/GRPCClient/GRPCCall.m
@@ -282,7 +282,7 @@ const char *kCFStreamVarName = "grpc_cfstream";
- (void)issueClosedWithTrailingMetadata:(NSDictionary *)trailingMetadata error:(NSError *)error {
if ([_handler respondsToSelector:@selector(closedWithTrailingMetadata:error:)]) {
- [_handler closedWithTrailingMetadata:_call.responseTrailers error:error];
+ [_handler closedWithTrailingMetadata:trailingMetadata error:error];
}
}
diff --git a/src/objective-c/GRPCClient/GRPCCallOptions.m b/src/objective-c/GRPCClient/GRPCCallOptions.m
index ecb517762b..9a36ee547c 100644
--- a/src/objective-c/GRPCClient/GRPCCallOptions.m
+++ b/src/objective-c/GRPCClient/GRPCCallOptions.m
@@ -45,7 +45,7 @@ static NSString *const kDefaultChannelPoolDomain = nil;
static const NSUInteger kDefaultChannelID = 0;
// Check if two objects are equal. Returns YES if both are nil;
-BOOL areObjectsEqual(id obj1, id obj2) {
+static BOOL areObjectsEqual(id obj1, id obj2) {
if (obj1 == obj2) {
return YES;
}
diff --git a/src/objective-c/GRPCClient/private/GRPCChannel.h b/src/objective-c/GRPCClient/private/GRPCChannel.h
index 6c58f4f387..32e68bb262 100644
--- a/src/objective-c/GRPCClient/private/GRPCChannel.h
+++ b/src/objective-c/GRPCClient/private/GRPCChannel.h
@@ -39,7 +39,7 @@ NS_ASSUME_NONNULL_BEGIN
* Options of the corresponding call. Note that only the channel-related options are of interest to
* this class.
*/
-@property(strong, readonly) GRPCCallOptions *callOptions;
+@property(readonly) GRPCCallOptions *callOptions;
/** Acquire the factory to generate a new channel with current configurations. */
@property(readonly) id<GRPCChannelFactory> channelFactory;