diff options
| author |  Noah Eisen <ncteisen@gmail.com> | 2018-07-16 11:38:29 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-07-16 11:38:29 -0700 |
| commit | d7fe925727b5201dd62aa9464c1685c474bbb4c8 (patch) | |
| tree | 2510cb3e805030e5f76b25f5f5e79b07e3e5ef2c | |
| parent | 0858d11e4539ee16d65768aa895b2d0dcb17eb74 (diff) | |
| parent | a99f776f6f03cf32dfc5842faca3893a7cf7e0ea (diff) | |
Merge pull request #16027 from ncteisen/spam
Reduce Spammy Logs
| -rw-r--r-- | src/core/lib/iomgr/ev_epollex_linux.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/core/lib/iomgr/ev_epollex_linux.cc b/src/core/lib/iomgr/ev_epollex_linux.cc index 5ffabdc665..7b368410cf 100644 --- a/src/core/lib/iomgr/ev_epollex_linux.cc +++ b/src/core/lib/iomgr/ev_epollex_linux.cc @@ -494,8 +494,9 @@ static void fd_orphan(grpc_fd* fd, grpc_closure* on_done, int* release_fd, is_fd_closed = true; } + // TODO(sreek): handle fd removal (where is_fd_closed=false) if (!is_fd_closed) { - gpr_log(GPR_DEBUG, "TODO: handle fd removal?"); + GRPC_FD_TRACE("epoll_fd %p (%d) was orphaned but not closed.", fd, fd->fd); } /* Remove the active status but keep referenced. We want this grpc_fd struct @@ -1564,7 +1565,7 @@ static void pollset_set_add_pollset_set(grpc_pollset_set* a, gpr_mu_unlock(b_mu); } // try to do the least copying possible - // TODO(ctiller): there's probably a better heuristic here + // TODO(sreek): there's probably a better heuristic here const size_t a_size = a->fd_count + a->pollset_count; const size_t b_size = b->fd_count + b->pollset_count; if (b_size > a_size) { |