diff options
author | 2017-08-11 16:11:26 -0700 | |
---|---|---|
committer | 2017-08-11 16:11:26 -0700 | |
commit | d36283ab594c4cf8fdffac700efeffa2705e6dc0 (patch) | |
tree | a4fdae5abb82cefef67f2a72018de64b5941e4c0 | |
parent | 69b8fe02b6a45a2731c17e91d6f22d85026fcd2f (diff) |
Address review comments
-rw-r--r-- | include/grpc/compression.h | 10 | ||||
-rw-r--r-- | src/core/ext/filters/http/message_compress/message_compress_filter.c | 12 |
2 files changed, 11 insertions, 11 deletions
diff --git a/include/grpc/compression.h b/include/grpc/compression.h index 15ae16c56c..3a8de4b7b8 100644 --- a/include/grpc/compression.h +++ b/include/grpc/compression.h @@ -30,15 +30,13 @@ extern "C" { #endif -/** Parses the first \a name_length bytes of \a name as a - * grpc_compression_algorithm instance, updating \a algorithm. Returns 1 upon - * success, 0 otherwise. */ +/** Parses the \a slice as a grpc_compression_algorithm instance and updating \a + * algorithm. Returns 1 upon success, 0 otherwise. */ GRPCAPI int grpc_compression_algorithm_parse( grpc_slice value, grpc_compression_algorithm *algorithm); -/** Parses the first \a name_length bytes of \a name as a - * grpc_stream_compression_algorithm instance, updating \a algorithm. Returns 1 - * upon success, 0 otherwise. */ +/** Parses the \a slice as a grpc_stream_compression_algorithm instance and + * updating \a algorithm. Returns 1 upon success, 0 otherwise. */ int grpc_stream_compression_algorithm_parse( grpc_slice name, grpc_stream_compression_algorithm *algorithm); diff --git a/src/core/ext/filters/http/message_compress/message_compress_filter.c b/src/core/ext/filters/http/message_compress/message_compress_filter.c index eb1a5a95e2..19ceed6780 100644 --- a/src/core/ext/filters/http/message_compress/message_compress_filter.c +++ b/src/core/ext/filters/http/message_compress/message_compress_filter.c @@ -125,17 +125,19 @@ static grpc_error *process_send_initial_metadata( GRPC_MDVALUE(md), &stream_compression_algorithm)) { char *val = grpc_slice_to_c_string(GRPC_MDVALUE(md)); gpr_log(GPR_ERROR, - "Invalid compression algorithm: '%s' (unknown). Ignoring.", val); + "Invalid stream compression algorithm: '%s' (unknown). Ignoring.", + val); gpr_free(val); stream_compression_algorithm = GRPC_STREAM_COMPRESS_NONE; } if (!GPR_BITGET(channeld->enabled_stream_compression_algorithms_bitset, stream_compression_algorithm)) { char *val = grpc_slice_to_c_string(GRPC_MDVALUE(md)); - gpr_log(GPR_ERROR, - "Invalid compression algorithm: '%s' (previously disabled). " - "Ignoring.", - val); + gpr_log( + GPR_ERROR, + "Invalid stream compression algorithm: '%s' (previously disabled). " + "Ignoring.", + val); gpr_free(val); stream_compression_algorithm = GRPC_STREAM_COMPRESS_NONE; } |