diff options
| author |  Vijay Pai <vpai@google.com> | 2015-04-04 10:15:08 -0700 |
|---|---|---|
| committer | Vijay Pai <vpai@google.com> | 2015-04-04 10:15:08 -0700 |
| commit | cf1a7e03e73b5e9b3c01d56398869650eb5ccb48 (patch) | |
| tree | 4a15555671fc31ebcc736368eb22b8f4a86f7833 | |
| parent | cc6017bb08ee315429c3e0aa1103232f07c556af (diff) | |
Remove the racy check added in commit i74c14e5ac752edc7e1dc0aaf31abfd1153df1d0a.
This is potentially unsafe since checking the deadline involves more than 1 word
read.
| -rw-r--r-- | src/core/iomgr/alarm.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/core/iomgr/alarm.c b/src/core/iomgr/alarm.c index 3b7092449a..5860834de3 100644 --- a/src/core/iomgr/alarm.c +++ b/src/core/iomgr/alarm.c @@ -307,10 +307,6 @@ static int run_some_expired_alarms(gpr_mu *drop_mu, gpr_timespec now, /* TODO(ctiller): verify that there are any alarms (atomically) here */ - if (gpr_time_cmp(g_shard_queue[0]->min_deadline, now) >= 0) { - return 0; - } - if (gpr_mu_trylock(&g_checker_mu)) { gpr_mu_lock(&g_mu); |