aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Craig Tiller <ctiller@google.com>2017-02-03 14:35:35 -0800
committerGravatar Craig Tiller <ctiller@google.com>2017-02-03 14:35:35 -0800
commitc80683d66f8928868b8c64903f78fa987f8ac9f1 (patch)
tree386c33e8e8c56742a9924a5f6c76d08d7ba2ba1d
parent0dad5d3b35cdfb2ab556797d9d91b6d0329e7d11 (diff)
parentd3c8fc005d4c2c97ae7d71210667e165dc9884ca (diff)
Merge branch 'bwest' into assert_writes
-rw-r--r--build.yaml2
-rw-r--r--templates/tools/run_tests/generated/tests.json.template2
-rw-r--r--test/core/end2end/bad_server_response_test.c2
-rw-r--r--test/core/end2end/tests/resource_quota_server.c5
-rw-r--r--test/core/transport/bdp_estimator_test.c3
-rw-r--r--tools/run_tests/generated/tests.json4
6 files changed, 9 insertions, 9 deletions
diff --git a/build.yaml b/build.yaml
index 0549cdc622..7fcad65d85 100644
--- a/build.yaml
+++ b/build.yaml
@@ -2955,6 +2955,8 @@ targets:
- grpc
- gpr_test_util
- gpr
+ args:
+ - --benchmark_min_time=0
platforms:
- mac
- linux
diff --git a/templates/tools/run_tests/generated/tests.json.template b/templates/tools/run_tests/generated/tests.json.template
index 1e21465dd2..2815dbb9b3 100644
--- a/templates/tools/run_tests/generated/tests.json.template
+++ b/templates/tools/run_tests/generated/tests.json.template
@@ -11,7 +11,7 @@
"gtest": tgt.gtest,
"exclude_configs": tgt.get("exclude_configs", []),
"exclude_iomgrs": tgt.get("exclude_iomgrs", []),
- "args": [],
+ "args": tgt.get("args", []),
"flaky": tgt.flaky,
"cpu_cost": tgt.get("cpu_cost", 1.0)}
for tgt in targets
diff --git a/test/core/end2end/bad_server_response_test.c b/test/core/end2end/bad_server_response_test.c
index d5f428eb82..42d960c428 100644
--- a/test/core/end2end/bad_server_response_test.c
+++ b/test/core/end2end/bad_server_response_test.c
@@ -135,7 +135,7 @@ static void handle_read(grpc_exec_ctx *exec_ctx, void *arg, grpc_error *error) {
gpr_log(GPR_DEBUG, "got %" PRIuPTR " bytes, expected %" PRIuPTR " bytes",
state.incoming_data_length, EXPECTED_INCOMING_DATA_LENGTH);
- if (state.incoming_data_length > EXPECTED_INCOMING_DATA_LENGTH) {
+ if (state.incoming_data_length >= EXPECTED_INCOMING_DATA_LENGTH) {
handle_write(exec_ctx);
} else {
grpc_endpoint_read(exec_ctx, state.tcp, &state.temp_incoming_buffer,
diff --git a/test/core/end2end/tests/resource_quota_server.c b/test/core/end2end/tests/resource_quota_server.c
index 3aeb9b27f3..4f9ed7a3a1 100644
--- a/test/core/end2end/tests/resource_quota_server.c
+++ b/test/core/end2end/tests/resource_quota_server.c
@@ -353,11 +353,6 @@ void resource_quota_server(grpc_end2end_test_config config) {
NUM_CALLS, cancelled_calls_on_server, cancelled_calls_on_client,
deadline_exceeded);
- /* The call may be cancelled after the server has sent its status but before
- * the client has received it. This means that we should see strictly more
- * failures on the client than on the server. */
- GPR_ASSERT(cancelled_calls_on_client >= cancelled_calls_on_server);
-
grpc_byte_buffer_destroy(request_payload);
grpc_slice_unref(request_payload_slice);
grpc_resource_quota_unref(resource_quota);
diff --git a/test/core/transport/bdp_estimator_test.c b/test/core/transport/bdp_estimator_test.c
index f72b40e1b7..f55a3ca643 100644
--- a/test/core/transport/bdp_estimator_test.c
+++ b/test/core/transport/bdp_estimator_test.c
@@ -124,7 +124,8 @@ static void test_get_estimate_random_values(size_t n) {
grpc_bdp_estimator est;
grpc_bdp_estimator_init(&est, "test");
int min = INT_MAX;
- int max = INT_MIN;
+ int max = 65535; // Windows rand() has limited range, make sure the ASSERT
+ // passes
for (size_t i = 0; i < n; i++) {
int sample = rand();
if (sample < min) min = sample;
diff --git a/tools/run_tests/generated/tests.json b/tools/run_tests/generated/tests.json
index d93b7e2a21..d60a501fe4 100644
--- a/tools/run_tests/generated/tests.json
+++ b/tools/run_tests/generated/tests.json
@@ -2452,7 +2452,9 @@
]
},
{
- "args": [],
+ "args": [
+ "--benchmark_min_time=0"
+ ],
"ci_platforms": [
"linux",
"mac",