diff options
author | 2018-05-23 16:54:32 -0700 | |
---|---|---|
committer | 2018-05-23 16:54:32 -0700 | |
commit | c38745833ae68f4d9a597c30f6ed16542e915cf9 (patch) | |
tree | f0a5d4a8156e5e0c4e1c3ca56e098c5d69c1b8ec | |
parent | 515908ba3196d057a8465a146f667b9e6c2ad9f2 (diff) | |
parent | 226a3d2ff66b4042ee2905d25970270a3d581e90 (diff) |
Merge pull request #15524 from AspirinSJL/revert_arena_fix
Revert arena size fix
-rw-r--r-- | src/core/lib/surface/call.cc | 8 | ||||
-rw-r--r-- | src/core/lib/surface/call.h | 5 | ||||
-rw-r--r-- | src/core/lib/surface/channel.cc | 3 |
3 files changed, 1 insertions, 15 deletions
diff --git a/src/core/lib/surface/call.cc b/src/core/lib/surface/call.cc index 86e0afa6ee..8946a7bedf 100644 --- a/src/core/lib/surface/call.cc +++ b/src/core/lib/surface/call.cc @@ -67,9 +67,6 @@ #define MAX_SEND_EXTRA_METADATA_COUNT 3 -// Used to create arena for the first call. -#define ESTIMATED_MDELEM_COUNT 16 - /* Status data for a request can come from several sources; this enumerates them all, and acts as a priority sorting for which status to return to the application - earlier entries override @@ -326,11 +323,6 @@ static parent_call* get_parent_call(grpc_call* call) { return (parent_call*)gpr_atm_acq_load(&call->parent_call_atm); } -size_t grpc_call_get_initial_size_estimate() { - return sizeof(grpc_call) + sizeof(batch_control) * MAX_CONCURRENT_BATCHES + - sizeof(grpc_linked_mdelem) * ESTIMATED_MDELEM_COUNT; -} - grpc_error* grpc_call_create(const grpc_call_create_args* args, grpc_call** out_call) { GPR_TIMER_SCOPE("grpc_call_create", 0); diff --git a/src/core/lib/surface/call.h b/src/core/lib/surface/call.h index e000f13e7d..793cce4efa 100644 --- a/src/core/lib/surface/call.h +++ b/src/core/lib/surface/call.h @@ -98,11 +98,6 @@ void* grpc_call_context_get(grpc_call* call, grpc_context_index elem); uint8_t grpc_call_is_client(grpc_call* call); -/* Get the estimated memory size for a call BESIDES the call stack. Combined - * with the size of the call stack, it helps estimate the arena size for the - * initial call. */ -size_t grpc_call_get_initial_size_estimate(); - /* Return an appropriate compression algorithm for the requested compression \a * level in the context of \a call. */ grpc_compression_algorithm grpc_call_compression_for_level( diff --git a/src/core/lib/surface/channel.cc b/src/core/lib/surface/channel.cc index a466b325be..0062d0d4d5 100644 --- a/src/core/lib/surface/channel.cc +++ b/src/core/lib/surface/channel.cc @@ -108,8 +108,7 @@ grpc_channel* grpc_channel_create_with_builder( gpr_atm_no_barrier_store( &channel->call_size_estimate, - (gpr_atm)CHANNEL_STACK_FROM_CHANNEL(channel)->call_stack_size + - grpc_call_get_initial_size_estimate()); + (gpr_atm)CHANNEL_STACK_FROM_CHANNEL(channel)->call_stack_size); grpc_compression_options_init(&channel->compression_options); for (size_t i = 0; i < args->num_args; i++) { |