diff options
author | Jan Tattermusch <jtattermusch@users.noreply.github.com> | 2018-04-25 21:02:14 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-04-25 21:02:14 +0200 |
commit | c12b0ed690590cb635e2b0563a0715607048263f (patch) | |
tree | 02a9c085dee017f6c6b315783b894718069c2c0c | |
parent | 246071a4e22d3d2ea19dad8714b19ef2dae5464a (diff) | |
parent | 5947d337fd94d156ba937555fb5492df24d7f3ba (diff) |
Merge pull request #15180 from jtattermusch/run_tests_auto_set_flakes_optin
run_tests.py --auto_set_flakes should be disabled by default
-rwxr-xr-x | tools/run_tests/run_tests.py | 8 | ||||
-rwxr-xr-x | tools/run_tests/run_tests_matrix.py | 1 |
2 files changed, 5 insertions, 4 deletions
diff --git a/tools/run_tests/run_tests.py b/tools/run_tests/run_tests.py index 6fb0f89381..0c270fa77e 100755 --- a/tools/run_tests/run_tests.py +++ b/tools/run_tests/run_tests.py @@ -1420,16 +1420,18 @@ argp.add_argument( nargs='?', help='Upload test results to a specified BQ table.') argp.add_argument( - '--disable_auto_set_flakes', + '--auto_set_flakes', default=False, const=True, action='store_const', - help='Disable rerunning historically flaky tests') + help= + 'Allow repeated runs for tests that have been failing recently (based on BQ historical data).' +) args = argp.parse_args() flaky_tests = set() shortname_to_cpu = {} -if not args.disable_auto_set_flakes: +if args.auto_set_flakes: try: for test in get_bqtest_data(): if test.flaky: flaky_tests.add(test.name) diff --git a/tools/run_tests/run_tests_matrix.py b/tools/run_tests/run_tests_matrix.py index 85f91b0446..64d80ab721 100755 --- a/tools/run_tests/run_tests_matrix.py +++ b/tools/run_tests/run_tests_matrix.py @@ -529,7 +529,6 @@ if __name__ == "__main__": extra_args.append('--bq_result_table') extra_args.append('%s' % args.bq_result_table) extra_args.append('--measure_cpu_costs') - extra_args.append('--disable_auto_set_flakes') all_jobs = _create_test_jobs(extra_args=extra_args, inner_jobs=args.inner_jobs) + \ _create_portability_test_jobs(extra_args=extra_args, inner_jobs=args.inner_jobs) |