diff options
| author |  David Garcia Quintas <dgq@google.com> | 2016-07-12 14:23:43 -0700 |
|---|---|---|
| committer | David Garcia Quintas <dgq@google.com> | 2016-07-12 14:23:43 -0700 |
| commit | c0299df85decd3197c45550f19c874a8d96b8318 (patch) | |
| tree | 2e77cbf5050dc87c1ede172ea84fcad07549bf4d | |
| parent | 04fae26cf6b21d0cddaefd47f8d075606d0ee3cb (diff) | |
added some more docs
| -rw-r--r-- | src/core/ext/load_reporting/load_reporting.h | 5 | ||||
| -rw-r--r-- | src/core/ext/transport/chttp2/transport/writing.c | 1 |
2 files changed, 5 insertions, 1 deletions
diff --git a/src/core/ext/load_reporting/load_reporting.h b/src/core/ext/load_reporting/load_reporting.h index 71e5a7c0ab..6a9772a2bd 100644 --- a/src/core/ext/load_reporting/load_reporting.h +++ b/src/core/ext/load_reporting/load_reporting.h @@ -58,8 +58,11 @@ typedef enum grpc_load_reporting_source { typedef struct grpc_load_reporting_call_data { const grpc_load_reporting_source source; /**< point of last data update. */ - // XXX + /** Unique identifier for the channel associated with the data */ intptr_t channel_id; + + /** Unique identifier for the call associated with the data. If the call + * hasn't been created yet, it'll have a value of zero. */ intptr_t call_id; /** Only valid when \a source is \a GRPC_LR_POINT_CALL_DESTRUCTION, that is, diff --git a/src/core/ext/transport/chttp2/transport/writing.c b/src/core/ext/transport/chttp2/transport/writing.c index 9182177ee8..a2ac8e8ec9 100644 --- a/src/core/ext/transport/chttp2/transport/writing.c +++ b/src/core/ext/transport/chttp2/transport/writing.c @@ -264,6 +264,7 @@ static void finalize_outbuf(grpc_exec_ctx *exec_ctx, send_bytes, is_last_frame, &stream_writing->stats, &transport_writing->outbuf); if (is_first_data_frame) { + /* TODO(dgq): this is a hack. It'll be fix in a future refactoring */ stream_writing->stats.data_bytes -= 5; /* discount grpc framing */ is_first_data_frame = false; } |