diff options
| author |  Jorge Canizales <jcanizales@google.com> | 2015-08-05 21:19:22 -0700 |
|---|---|---|
| committer | Jorge Canizales <jcanizales@google.com> | 2015-08-05 21:29:28 -0700 |
| commit | 7e90745b3c609d12dfc63ca6cdddac9446b3d5e5 (patch) | |
| tree | c5260637e22fe79673f02d61c7884b209ef8b451 | |
| parent | 77723b127a2eafd1f99a7a3362371be310d5df29 (diff) | |
Document plan to merge the GRPCChannel subclasses
| -rw-r--r-- | src/objective-c/GRPCClient/private/GRPCSecureChannel.m | 2 | ||||
| -rw-r--r-- | src/objective-c/GRPCClient/private/GRPCUnsecuredChannel.m | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/src/objective-c/GRPCClient/private/GRPCSecureChannel.m b/src/objective-c/GRPCClient/private/GRPCSecureChannel.m index d3c4d41a13..9b4b6768f8 100644 --- a/src/objective-c/GRPCClient/private/GRPCSecureChannel.m +++ b/src/objective-c/GRPCClient/private/GRPCSecureChannel.m @@ -102,6 +102,8 @@ static grpc_credentials *CertificatesAtPath(NSString *path, NSError **errorPtr) [super initWithChannel:grpc_secure_channel_create(credentials, host.UTF8String, args)]); } +// TODO(jcanizales): GRPCSecureChannel and GRPCUnsecuredChannel are just convenience initializers +// for GRPCChannel. Move them into GRPCChannel, which will make the following unnecessary. - (instancetype)initWithChannel:(grpc_channel *)unmanagedChannel { [NSException raise:NSInternalInconsistencyException format:@"use another initializer"]; return [self initWithHost:nil]; // silence warnings diff --git a/src/objective-c/GRPCClient/private/GRPCUnsecuredChannel.m b/src/objective-c/GRPCClient/private/GRPCUnsecuredChannel.m index 5decfba7e3..070a529629 100644 --- a/src/objective-c/GRPCClient/private/GRPCUnsecuredChannel.m +++ b/src/objective-c/GRPCClient/private/GRPCUnsecuredChannel.m @@ -41,6 +41,8 @@ return (self = [super initWithChannel:grpc_insecure_channel_create(host.UTF8String, NULL)]); } +// TODO(jcanizales): GRPCSecureChannel and GRPCUnsecuredChannel are just convenience initializers +// for GRPCChannel. Move them into GRPCChannel, which will make the following unnecessary. - (instancetype)initWithChannel:(grpc_channel *)unmanagedChannel { [NSException raise:NSInternalInconsistencyException format:@"use the other initializer"]; return [self initWithHost:nil]; // silence warnings |