diff options
| author |  Mehrdad Afshari <mmx@google.com> | 2017-03-22 14:07:00 -0700 |
|---|---|---|
| committer | Mehrdad Afshari <mmx@google.com> | 2017-03-23 09:19:23 -0700 |
| commit | 626efa67f0101af6bb4f6505b0eef848b148585a (patch) | |
| tree | 184951ec3406cee2015457a75a15a64e570c8bc4 | |
| parent | 7472e13095b15f65654f2e463a10bfbf616c2d72 (diff) | |
Temporarily disable testFileContainingExtension
There is a behavioral discrepency in
`DescriptorPool.FindFileContainingSymbol` between the two
implementations of the protobuf python library (one of which is purely
python, and the other utilizes a python extension library written in
C++).
protobuf on PyPI is distributed via various prebuilt wheels, and our CI
setup fetches the relevant one for each platform. Our Linux instances
end up fetching a pre-compiled C++ version of the library, whereas our
Mac and Windows builders automatically get the pure python version.
This test fails (and our reflection implementation itself) succeeds with
the C++ implementation but fails with the pure python version.
The test will be temporarily disabled pending a fix for
https://github.com/google/protobuf/issues/2882
| -rw-r--r-- | src/python/grpcio_tests/tests/reflection/_reflection_servicer_test.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/python/grpcio_tests/tests/reflection/_reflection_servicer_test.py b/src/python/grpcio_tests/tests/reflection/_reflection_servicer_test.py index 69192a2b74..56b85c2dd0 100644 --- a/src/python/grpcio_tests/tests/reflection/_reflection_servicer_test.py +++ b/src/python/grpcio_tests/tests/reflection/_reflection_servicer_test.py @@ -114,6 +114,9 @@ class ReflectionServicerTest(unittest.TestCase): )),) self.assertSequenceEqual(expected_responses, responses) + @unittest.skip( + 'TODO(mmx): enable when (pure) python protobuf issue is fixed' + '(see https://github.com/google/protobuf/issues/2882)') def testFileContainingExtension(self): requests = (reflection_pb2.ServerReflectionRequest( file_containing_extension=reflection_pb2.ExtensionRequest( |