diff options
| author |  Juanli Shen <aspirinsjl@gmail.com> | 2018-08-16 15:23:36 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-08-16 15:23:36 -0700 |
| commit | 61dabce400f3b139205e8f983e167d9ed6e7e6d4 (patch) | |
| tree | 92f439bbff6af0e5cf7ef7555cc42bb4bb3c3b4d | |
| parent | 7e4be890148cae7d9350007d4372f7492c52569c (diff) | |
| parent | 5e9994bf309a4fbf0206bf5312758f0c2a23aa3d (diff) | |
Merge pull request #16289 from AspirinSJL/warn_api_use
Add warning about AsyncNotifyWhenDone bug
| -rw-r--r-- | include/grpcpp/impl/codegen/server_context.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/grpcpp/impl/codegen/server_context.h b/include/grpcpp/impl/codegen/server_context.h index 10372de129..6314364db6 100644 --- a/include/grpcpp/impl/codegen/server_context.h +++ b/include/grpcpp/impl/codegen/server_context.h @@ -227,6 +227,8 @@ class ServerContext { /// Async only. Has to be called before the rpc starts. /// Returns the tag in completion queue when the rpc finishes. /// IsCancelled() can then be called to check whether the rpc was cancelled. + /// TODO(vjpai): Fix this so that the tag is returned even if the call never + /// starts (https://github.com/grpc/grpc/issues/10136). void AsyncNotifyWhenDone(void* tag) { has_notify_when_done_tag_ = true; async_notify_when_done_tag_ = tag; |