aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Yang Gao <yangg@google.com>2015-03-15 21:58:16 -0700
committerGravatar Yang Gao <yangg@google.com>2015-03-15 21:58:16 -0700
commit4c3ee74d4eaa8ad2772f9a069e41813cd8188956 (patch)
treefe1b1674811aafb5a6291cb4106865e31576d815
parent42a2e6f1b7e19c99ccb6a97822386206f67bcf48 (diff)
parentb486ba6b0d488b0331cd56d1fac6fd28935c7c46 (diff)
Merge pull request #1043 from icodeplus/remove_else_code
remove 'else' code, release lock by destructor
-rw-r--r--src/cpp/server/server.cc12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/cpp/server/server.cc b/src/cpp/server/server.cc
index e69032a657..8729680565 100644
--- a/src/cpp/server/server.cc
+++ b/src/cpp/server/server.cc
@@ -179,12 +179,12 @@ Server::Server(ThreadPoolInterface* thread_pool, bool thread_pool_owned)
thread_pool_owned_(thread_pool_owned) {}
Server::~Server() {
- std::unique_lock<std::mutex> lock(mu_);
- if (started_ && !shutdown_) {
- lock.unlock();
- Shutdown();
- } else {
- lock.unlock();
+ {
+ std::unique_lock<std::mutex> lock(mu_);
+ if (started_ && !shutdown_) {
+ lock.unlock();
+ Shutdown();
+ }
}
grpc_server_destroy(server_);
if (thread_pool_owned_) {