aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Noah Eisen <ncteisen@gmail.com>2018-04-09 14:29:46 -0700
committerGravatar GitHub <noreply@github.com>2018-04-09 14:29:46 -0700
commit427adb247c2129a123a82c79a03a69d9ec7e7ad0 (patch)
tree15e403d37bfae11efb9b7a684ef97a4ee078ab8f
parenta9c996028884e9d8d6cd2257050d68e25ce20830 (diff)
parent9d0c2462943a3a5e69c1a69a4385bc7204eb5674 (diff)
Merge pull request #14986 from ncteisen/trace
Fix Spammy Log on Empty GRPC_TRACE Var
-rw-r--r--src/core/lib/debug/trace.cc3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/core/lib/debug/trace.cc b/src/core/lib/debug/trace.cc
index b0e0f2ba7c..01c1e867d9 100644
--- a/src/core/lib/debug/trace.cc
+++ b/src/core/lib/debug/trace.cc
@@ -55,7 +55,8 @@ bool TraceFlagList::Set(const char* name, bool enabled) {
found = true;
}
}
- if (!found) {
+ // check for unknowns, but ignore "", to allow to GRPC_TRACE=
+ if (!found && 0 != strcmp(name, "")) {
gpr_log(GPR_ERROR, "Unknown trace var: '%s'", name);
return false; /* early return */
}