aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Tim Emiola <tbetbetbe@users.noreply.github.com>2015-09-17 10:24:29 -0700
committerGravatar Tim Emiola <tbetbetbe@users.noreply.github.com>2015-09-17 10:24:29 -0700
commit3c142b8bcc6b87d34854772816553825a8705bdf (patch)
tree53e7e1d3f00493aeaad593bf4f7069991464ec09
parent3115638631b10ed79b8edb59669021c6050d46ef (diff)
parenta59ee9a30792b8d5bb5e42b481c18f6222a67577 (diff)
Merge pull request #3345 from murgatroid99/node_callback_this
Fixed a couple of incorrect "this" references in Node library
-rw-r--r--src/node/src/server.js6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/node/src/server.js b/src/node/src/server.js
index b6f162adf8..70b4a9d80e 100644
--- a/src/node/src/server.js
+++ b/src/node/src/server.js
@@ -276,6 +276,7 @@ function ServerWritableStream(call, serialize) {
function _write(chunk, encoding, callback) {
/* jshint validthis: true */
var batch = {};
+ var self = this;
if (!this.call.metadataSent) {
batch[grpc.opType.SEND_INITIAL_METADATA] =
(new Metadata())._getCoreRepresentation();
@@ -290,7 +291,7 @@ function _write(chunk, encoding, callback) {
batch[grpc.opType.SEND_MESSAGE] = message;
this.call.startBatch(batch, function(err, value) {
if (err) {
- this.emit('error', err);
+ self.emit('error', err);
return;
}
callback();
@@ -305,6 +306,7 @@ ServerWritableStream.prototype._write = _write;
*/
function sendMetadata(responseMetadata) {
/* jshint validthis: true */
+ var self = this;
if (!this.call.metadataSent) {
this.call.metadataSent = true;
var batch = [];
@@ -312,7 +314,7 @@ function sendMetadata(responseMetadata) {
responseMetadata._getCoreRepresentation();
this.call.startBatch(batch, function(err) {
if (err) {
- this.emit('error', err);
+ self.emit('error', err);
return;
}
});