aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Nathaniel Manista <nathaniel@google.com>2017-06-24 21:03:21 +0000
committerGravatar Nathaniel Manista <nathaniel@google.com>2017-06-24 21:03:21 +0000
commit37c83ffbed4e01f02d4fdee3e8e9156e877d4608 (patch)
tree25f61f37bbbb338b68f2172e8317fe89e0be52c8
parenta7182f7f5a7253bbcd33eabff1b3ec4fb686edb0 (diff)
Enable redefined-variable-type lint
-rw-r--r--.pylintrc3
-rw-r--r--src/python/grpcio/grpc/_channel.py5
2 files changed, 5 insertions, 3 deletions
diff --git a/.pylintrc b/.pylintrc
index e7b4eb0109..15062dca9c 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -31,9 +31,8 @@ notes=FIXME,XXX
# disable=cyclic-import suppressions.
#TODO: Enable too-many-instance-attributes
#TODO: Enable too-many-lines
-#TODO: Enable redefined-variable-type
#TODO: Enable import-error
#TODO: Enable useless-else-on-loop
#TODO: Enable too-many-nested-blocks
-disable=missing-docstring,too-few-public-methods,no-init,duplicate-code,invalid-name,locally-disabled,protected-access,no-name-in-module,wrong-import-order,cyclic-import,too-many-instance-attributes,too-many-lines,redefined-variable-type,import-error,useless-else-on-loop,too-many-nested-blocks
+disable=missing-docstring,too-few-public-methods,no-init,duplicate-code,invalid-name,locally-disabled,protected-access,no-name-in-module,wrong-import-order,cyclic-import,too-many-instance-attributes,too-many-lines,import-error,useless-else-on-loop,too-many-nested-blocks
diff --git a/src/python/grpcio/grpc/_channel.py b/src/python/grpcio/grpc/_channel.py
index 1562c3e24d..cf4ce0941b 100644
--- a/src/python/grpcio/grpc/_channel.py
+++ b/src/python/grpcio/grpc/_channel.py
@@ -849,7 +849,10 @@ def _poll_connectivity(state, channel, initial_try_to_connect):
_common.CYGRPC_CONNECTIVITY_STATE_TO_CHANNEL_CONNECTIVITY[
connectivity])
if not state.delivering:
- callbacks = _deliveries(state)
+ # NOTE(nathaniel): The field is only ever used as a
+ # sequence so it's fine that both lists and tuples are
+ # assigned to it.
+ callbacks = _deliveries(state) # pylint: disable=redefined-variable-type
if callbacks:
_spawn_delivery(state, callbacks)